Skip to content

Look for arm64 binaries in _arm64 dirs #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2025
Merged

Look for arm64 binaries in _arm64 dirs #95

merged 1 commit into from
Feb 15, 2025

Conversation

@felthy
Copy link

@felthy felthy commented Feb 13, 2025

Relates to #89 and #90.

When I tried running the latest code on a Mac with arm64 architecture and without Rosetta installed, it failed because it was still trying to execute bin/darwin/msdfgen.osx. I’ve updated the binaryPath to fix this, which should fix both MacOS and Linux.

Also renamed the var from lookupKey to platformKey so it makes more sense to use it as part of binaryPath.

@soimy soimy merged commit 3b4cc09 into soimy:master Feb 15, 2025
3 checks passed
soimy added a commit that referenced this pull request Aug 25, 2025
@soimy
Squashed commit of the following:
44cfc6d 
commit ccd8345
Author: Shen Yiming <[email protected]>
Date:   Tue Aug 26 00:50:27 2025 +0800

    docs: fix README en version misplaced paragraph about msdfgen

commit 649974c
Author: Shen Yiming <[email protected]>
Date:   Tue Aug 26 00:40:39 2025 +0800

    chore(release): 2.8.0

commit 3383f3c
Author: Shen Yiming <[email protected]>
Date:   Tue Aug 26 00:38:18 2025 +0800

    docs: update README and misc docs

commit 48460fb
Author: Shen Yiming <[email protected]>
Date:   Tue Aug 26 00:02:27 2025 +0800

    Feat/major dependency updates (#97)

    * fix(deps): update handlebars and load-bmfont

    * Update node.js.yml
    drop old nodejs version 12.x 14.x and 16.x

    * feat: installation script for `msdfgen` latest binary on all supported platforms

    * chore: Action now supports all platforms

    * feat: add multi-stage CI workflow with rate limiting protection

    - Add 5-stage testing strategy across all platforms
    - Include Windows, macOS (Intel & Apple Silicon), Linux x64 & ARM64
    - Implement rate limiting protection with random delays
    - Add retry mechanisms for npm installation
    - Use GitHub Token for authentication
    - Optimize resource usage with staged execution

    # Conflicts:
    #	.github/workflows/node.js.yml

    * fixed: Removed render in npm test

    * build: include msdfgen binary for all platform & download script

    use npm run update-msdfgen-all to update msdfgen binaries

    * ci: simplify test ci

    * ci: fix free runner label macos-13 instead of macos-latest-large

    * docs: fix markdown style violation

    * fix: msdfgen macos-x64 binary arch error

    * fix: msdfgen binary install script check update logic error
    running check should only been performed on current platform

commit bd28cc0
Author: Shen Yiming <[email protected]>
Date:   Sat Aug 23 12:07:55 2025 +0800

    fix: remove node test.js render in npm run test

commit 2c149bd
Author: Shen Yiming <[email protected]>
Date:   Thu Aug 14 23:55:12 2025 +0800

    fix(deps): update handlebars and load-bmfont

commit eb7bc25
Author: Shen Yiming <[email protected]>
Date:   Tue Aug 19 10:38:28 2025 +0800

    Update node.js.yml

    drop old nodejs version 12.x 14.x and 16.x

commit 22b118d
Author: Shen Yiming <[email protected]>
Date:   Tue Aug 19 10:35:32 2025 +0800

    Update node.js.yml

commit 3e021c9
Author: albinkong <[email protected]>
Date:   Thu Aug 14 15:52:55 2025 +0200

    Upgrade jimp to 1.6.0 (#96)

    * Upgrade jimp to 1.6.0

    * Bump serve-handler minor version

    Removes use of deprecated node package

commit 3b4cc09
Author: Pete Feltham <[email protected]>
Date:   Sat Feb 15 16:19:16 2025 +1100

    Look for arm64 binaries in _arm64 dirs (#95)

commit 523c5e5
Author: h1ve2 <[email protected]>
Date:   Sat Feb 15 13:18:02 2025 +0800

    feat: add an optional logger (#94)

    * feat: add an optional logger

    * Create defaultLogger and export it

    * Import defaultLogger and replace console with logger

commit 56adc10
Author: Frank Weindel <[email protected]>
Date:   Tue Feb 11 09:36:33 2025 -0500

    Fix baseline alignment (#93)

commit 5a2495a
Author: Ari Lotter <[email protected]>
Date:   Fri Jun 16 09:37:45 2023 -0400

    feat: Add arm64 MacOS compatibility (#90)

commit 0cb2817
Author: tkwiatek <[email protected]>
Date:   Sun Jun 4 06:25:11 2023 +0200

    feat: Add arm64 linux compatibility (#89)

    * feat: Add arm64 linux compatibility
    * chore: Update deps
    * chore: Update msdfgen.linux binary to newest version

    ---------

    Co-authored-by: Leo Bergman <[email protected]>

commit 986b9cc
Author: Shen Yiming <[email protected]>
Date:   Sun Jul 24 00:00:01 2022 +0800

    chore(release): 2.7.0

commit 2eaa125
Author: Shen Yiming <[email protected]>
Date:   Sat Jul 23 23:40:28 2022 +0800

    docs: update Docs for txt(.fnt) format and BMFont format description

commit 30168bb
Author: Shen Yiming <[email protected]>
Date:   Sat Jul 23 23:34:11 2022 +0800

    chore: update & cleanup modules

commit 34d8976
Author: Shen Yiming <[email protected]>
Date:   Sat Jul 23 22:53:11 2022 +0800

    feat: add new output type: txt

    an alternative .fnt format other than xml, which is accpetable by Godot & Defold

commit 235bce6
Author: Shen Yiming <[email protected]>
Date:   Tue Feb 15 11:01:04 2022 +0800

    Create node.js.yml

commit 47cc4f9
Author: Shen Yiming <[email protected]>
Date:   Tue Feb 1 21:56:06 2022 +0800

    Update Readme

commit 17a79b9
Author: Shen Yiming <[email protected]>
Date:   Mon Jan 31 21:36:06 2022 +0800

    chore(release): 2.6.0

commit c193d38
Author: Ankush Sharma <[email protected]>
Date:   Thu May 6 09:28:23 2021 +0530

    Upgrade Jimp 0.16.1 (#63)

    Update package.json

commit b6c8f6b
Author: Phil <[email protected]>
Date:   Mon Feb 8 02:05:50 2021 -0700

    Fix binary path not working when containing spaces (#59)

commit 5209f7c
Author: bloodmage <[email protected]>
Date:   Mon Jun 22 12:42:52 2020 +0800

    Using stdin to transfer shapeDesc (#52)

    For some complex CJK fonts, length of shapeDesc may exceed limitation on Windows (which is 8191 characters for command line & arguments).
    Using stdin solves this problem.

commit 23aace9
Author: Shen Yiming <[email protected]>
Date:   Sun Feb 9 02:26:53 2020 +0800

    feat: Add version update-notifier

commit e05c94d
Author: Shen Yiming <[email protected]>
Date:   Sun Feb 9 02:16:09 2020 +0800

    chore(release): 2.5.4

commit 3b57562
Author: Shen Yiming <[email protected]>
Date:   Sun Feb 9 02:03:27 2020 +0800

    fix: Re-use cfg settings not applied

    and re-used atlas file autosizing not applied

    fix #44

commit c37cc40
Author: Shen Yiming <[email protected]>
Date:   Sat Feb 8 21:06:02 2020 +0800

    fix: CLI&document for SVG debug generation from `-t svg` to `-v`

    fix #46

commit ae559fd
Author: Shen Yiming <[email protected]>
Date:   Sun Feb 2 15:06:58 2020 +0800

    fix: omit path in font-face

    fix #49

commit 7b1f2a7
Author: Shen Yiming <[email protected]>
Date:   Sun Jan 26 11:32:38 2020 +0800

    chore(release): 2.5.3

commit 12a60e3
Author: Shen Yiming <[email protected]>
Date:   Sun Jan 26 11:32:20 2020 +0800

    refactor: Update arabic-persian-reshaper API & version

commit 6b659b4
Author: Don McCurdy <[email protected]>
Date:   Fri Jan 17 19:37:52 2020 -0800

    Support 'fontBuffer' parameter for in-memory generation. (#48)

    - Fixes #47.

commit bbf8286
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Jan 18 11:34:45 2020 +0800

    Bump handlebars from 4.1.2 to 4.3.0 (#45)

    Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.3.0.
    - [Release notes](https://github.com/wycats/handlebars.js/releases)
    - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
    - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.3.0)

    Signed-off-by: dependabot[bot] <[email protected]>

commit 09b1171
Author: Jo <[email protected]>
Date:   Sat Jan 18 04:34:01 2020 +0100

    output padding info by default (#43)

commit ff3669c
Author: Shen Yiming <[email protected]>
Date:   Fri Jul 12 20:46:12 2019 +0800

    chore(release): 2.5.2

commit 230d0b3
Author: Shen Yiming <[email protected]>
Date:   Fri Jul 12 20:45:51 2019 +0800

    fix: async texture generation skips fontData stringify

    fix #39

commit e5c15ee
Author: Shen Yiming <[email protected]>
Date:   Thu Jul 11 20:59:31 2019 +0800

    chore(release): 2.5.1

commit 612da74
Author: Shen Yiming <[email protected]>
Date:   Thu Jul 11 20:59:17 2019 +0800

    chore: back to npm

commit 007a6c5
Merge: 5d95b32 84732bf
Author: Shen Yiming <[email protected]>
Date:   Thu Jul 11 20:54:12 2019 +0800

    Merge branch 'master' of https://github.com/soimy/msdf-bmfont-xml

commit 5d95b32
Author: Shen Yiming <[email protected]>
Date:   Thu Jul 11 20:53:14 2019 +0800

    fix: async jimp.read() should be fulfilled before continue packing

commit 84732bf
Author: Shen Yiming <[email protected]>
Date:   Tue Jul 2 10:28:38 2019 +0800

    fix: package script render changed to yarn

commit 16759b3
Author: Shen Yiming <[email protected]>
Date:   Thu Jun 27 11:54:23 2019 +0800

    docs: Update Readme to reflect new `border` option

commit 071b016
Author: Shen Yiming <[email protected]>
Date:   Tue Jun 25 18:18:53 2019 +0800

    test: Fix run render by replacing abandoned devtools

    Now uses pixi.js & pixi-msdf-text to render msdf font files in system default browser

    fix #38

commit 9fd9aa9
Author: Shen Yiming <[email protected]>
Date:   Thu Jun 20 00:38:22 2019 +0800

    chore(release): 2.5.0

commit 33598b9
Author: Shen Yiming <[email protected]>
Date:   Thu Jun 20 00:37:26 2019 +0800

    feat: new border option to control packing space to atlas edge

commit a1494ca
Author: Shen Yiming <[email protected]>
Date:   Thu Jun 20 00:36:10 2019 +0800

    chore: npm -> yarn, add some dev toolchain

commit 2d853e7
Author: Shen Yiming <[email protected]>
Date:   Mon Jun 3 19:39:14 2019 +0800

    Version 2.4.3 - Fix: json string strict casting

commit 5aef27e
Author: Shen Yiming <[email protected]>
Date:   Mon Jun 3 19:37:35 2019 +0800

    Fix: #28 json string strict casting

commit 24a72ab
Author: Shen Yiming <[email protected]>
Date:   Mon May 13 22:51:30 2019 +0800

    README add npm monthly download badge

commit bb525ec
Author: Shen Yiming <[email protected]>
Date:   Sat May 11 21:51:50 2019 +0800

    Fix -rot in npm test
    Turns out rot packing is useless in bmfont

commit f1e5b6c
Author: Shen Yiming <[email protected]>
Date:   Thu May 9 16:34:33 2019 +0800

    Version 2.4.2 - New options: allowRotation

commit c2f8ea8
Author: Shen Yiming <[email protected]>
Date:   Thu May 9 16:34:22 2019 +0800

    Update comment & README

commit f55d3ef
Author: Shen Yiming <[email protected]>
Date:   Thu May 9 16:22:39 2019 +0800

    Cleanup codes

commit 16cc94d
Author: Shen Yiming <[email protected]>
Date:   Thu May 9 16:21:04 2019 +0800

    Fix vulnerabilities

commit 7f68279
Author: Shen Yiming <[email protected]>
Date:   Thu May 9 16:10:34 2019 +0800

    Allow 90-degree rotation in packing

commit 90a285a
Author: Shen Yiming <[email protected]>
Date:   Tue May 7 17:06:54 2019 +0800

    Version 2.4.1 - Fix cli parameter type casting bug

commit 4929a54
Merge: d251e03 d3030e6
Author: Shen Yiming <[email protected]>
Date:   Tue May 7 17:03:58 2019 +0800

    Merge remote-tracking branch 'origin/develop'

    # Conflicts:
    #	package-lock.json

commit d251e03
Author: Damien Mortini <[email protected]>
Date:   Mon May 6 06:48:00 2019 +0200

    force number type on texturePadding to avoid type error in MaxRectsPacker when using cli (#33)

    Or it will broke the whole process.

commit e22589b
Author: Shen Yiming <[email protected]>
Date:   Mon Mar 18 15:21:58 2019 +0800

    Version 2.4.0 - Replace Node-Canvas with Jimp

commit 5b92447
Merge: 7fbcb77 3911e85
Author: Shen Yiming <[email protected]>
Date:   Mon Mar 18 15:13:18 2019 +0800

    Merge remote-tracking branch 'origin/canvas2jimp'

    Replace problematic node-canvas with jimp for lightweight image processing

commit 7fbcb77
Author: Shen Yiming <[email protected]>
Date:   Thu Mar 14 15:46:25 2019 +0800

    Version 2.3.6 - Json numeric char parse fix & Dep. update

commit 4b1ad9b
Merge: 6142b5b 67cd028
Author: Shen Yiming <[email protected]>
Date:   Thu Mar 14 15:39:09 2019 +0800

    Merge branch 'develop'

    - Fixed json numeric charactor parse error via 4f8ab26
    - Update dependencies & fixed vulnerabilties via 30d8967
    - Update README on outdated textureSize parameter via 67cd028

commit 6142b5b
Author: Ignacio Julve <[email protected]>
Date:   Thu Mar 14 03:28:49 2019 +0100

    Solves Issue#30 by updating dependencies (#31)

    * Solves Issue#30 by updating dependencies

    Signed-off-by: Ignacio Julve <[email protected]>

    * Bump version of the library

    Signed-off-by: Ignacio Julve <[email protected]>

commit d05ef86
Author: Shen Yiming <[email protected]>
Date:   Fri Jun 29 15:01:59 2018 +0800

    Version 2.3.5 - Changing CLI default parameters

commit a9b05b2
Author: Shen Yiming <[email protected]>
Date:   Fri Jun 29 14:56:03 2018 +0800

    Update dependencies

commit 71e08a5
Author: Shen Yiming <[email protected]>
Date:   Fri Jun 29 14:33:00 2018 +0800

    Change Default value for texture size & smart-size

    Squashed commit d14db9a
    Author: Shen Yiming <[email protected]>
    Date:   Fri Jun 29 13:23:03 2018 +0800
    Change Default value for texture size & smart-size

commit 5f8f290
Author: Shen Yiming <[email protected]>
Date:   Fri Feb 16 22:24:28 2018 +0800

    Version 2.3.4 - Fix linux/darwin msdfgen executable permission bug

commit 28acaec
Author: Shen Yiming <[email protected]>
Date:   Thu Feb 15 15:32:59 2018 +0800

    Version 2.3.3 - Update msdfgen linux binary

commit bca20ca
Author: Shen Yiming <[email protected]>
Date:   Thu Feb 15 15:30:09 2018 +0800

    Update msdfgen binary to ckohnet's fork and cleanup/reorganized bin folder  (#22)

    * Adapt the maxrects_packer v2

    * Fixed bug: omit output filename lead to double path appended.

    * Fix bugs:
    1. Typo "Generating",
    2. Ignore control charators in charset,
    3. Omit index in filename if only one altas

    * update npm
    add yargs cli frontend

    * WIP: changing cli module

    * Implemented cli default value, reuse can mannually specify filename. Test needed

    * Fixed bug with manually assign cfg file

    * Cleanup & update dependency

    * repaire msdfgen win32 binary

    * Update msdfgen executable permission

    * Update linux binary with local shared libraries.
    Using `patchelf --set-rpath '$ORIGIN/lib' ./msdfgen.linux

    * Remove unnessecery shared library

    * Add missing libstdc++ dependency for msdfgen linux binary

    * Bump canvas-prebuilt version for libpng12.so.12 issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felthy @soimy