Fix early termination of SNMP walks when encountering None values#370
Open
spandan-nexthop wants to merge 1 commit intosonic-net:masterfrom
Open
Fix early termination of SNMP walks when encountering None values#370spandan-nexthop wants to merge 1 commit intosonic-net:masterfrom
spandan-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
Fix SNMP GETNEXT skipping valid entries after encountering interface with missing counters When _get_nextvalue() encounters an interface whose counters are not present in COUNTERS_DB (returning None), it returns immediately instead of advancing to the next sub_id. This causes SNMP walks (GETNEXT operations) to jump to the next MIB subtree, silently skipping all remaining valid entries such as PortChannel interfaces and such that could come after the ports without counter support in the OID ordering. Fix by looping through subsequent sub_ids when a None value is encountered, returning only once a valid value is found or all entries are exhausted. Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
Hi @qiluo-msft , can you or someone from your team help review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #369
Fixes: sonic-net/sonic-buildimage#26489
- What I did
Fix SNMP GETNEXT skipping valid entries after encountering interface with missing counters
When _get_nextvalue() encounters an interface whose counters are not present in COUNTERS_DB (returning None), it returns immediately instead of advancing to the next sub_id. This causes SNMP walks (GETNEXT operations) to jump to the next MIB subtree, silently skipping all remaining valid entries such as PortChannel interfaces and such that could come after the ports without counter support in the OID ordering.
- How I did it
Fix by looping through subsequent sub_ids when a None value is encountered, returning only once a valid value is found or all entries are exhausted.
- How to verify it
The steps to reproduce that are mentioned in the actual Issue linked above, can be re-run with this fix.
- Description for the changelog