This repository was archived by the owner on Mar 16, 2021. It is now read-only.
Change username properties#50
Open
andreaubbiali wants to merge 1 commit intosorintlab:masterfrom
2h3ph3rd:username
Open
Change username properties#50andreaubbiali wants to merge 1 commit intosorintlab:masterfrom 2h3ph3rd:username
andreaubbiali wants to merge 1 commit intosorintlab:masterfrom
2h3ph3rd:username
Conversation
Contributor
andreaubbiali
commented
Nov 5, 2018
andreaubbiali
commented
- increase max length to 40 chars
- allow dots and underscores
- fix test
sgotti
suggested changes
Nov 6, 2018
Member
sgotti
left a comment
sgotti
left a comment
There was a problem hiding this comment.
Thanks for the PR. Just a small nit, then it LGTM.
| "time" | ||
|
|
||
| "github.com/asaskevich/govalidator" | ||
| "github.com/pkg/errors" |
Member
There was a problem hiding this comment.
These imports were below and with a new line from the Iocal ones to separate them (it's idiomatic doing this with go just for clearness). Can you please remove this change?
- increase max length to 40 chars - allow dots and underscores - fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.