Add more FunctionDeclarationKinds for the visitor #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR fixes some minor issues:
FunctionDeclarationKind.OTHER
when they should beFunctionDeclarationKind.DIV
int_to_bv
,ubv_to_int
andsbv_to_int
. These are need to convert between bitvector and integer terms, and while were able to create such terms withBitvectorFormulaManager.makeBitvector(int length, IntegerFormula pI)
andBitvectorFormulaManager.toIntegerFormula)
they were not properly supported by the visitorTODO
int_to_bv
is an indexed function and will need to be supported in the visitor