Skip to content

🎨 Palette: Accessible Overlay Controls#33

Open
soulllink wants to merge 1 commit intomainfrom
palette-a11y-overlay-controls-12780993086271786337
Open

🎨 Palette: Accessible Overlay Controls#33
soulllink wants to merge 1 commit intomainfrom
palette-a11y-overlay-controls-12780993086271786337

Conversation

@soulllink
Copy link
Owner

🎨 Palette: Improved accessibility for Overlay Controls

💡 What: Added aria-label attributes to all icon-only buttons, sliders, and inputs in the main control overlay.
🎯 Why: Screen readers were unable to identify the purpose of these controls, as they relied solely on visual icons or short text codes ("B", "L").
📸 Visuals: No visual changes (attribute-only update).
Accessibility:

  • All 6 image adjustment sliders now have accessible names (e.g., "Brightness", "Contrast").
  • View mode buttons now announce full names (e.g., "Reader Mode" instead of just "B").
  • Icon-only buttons (Settings, OCR, etc.) are now fully accessible.

PR created automatically by Jules for task 12780993086271786337 started by @soulllink

- Adds `aria-label` to all icon-only buttons in `OverlayControls.svelte` and `MacroRecorder.svelte`.
- Adds `aria-label` to range inputs (sliders) in `OverlayControls.svelte` for Brightness, Contrast, Saturation, Hue, Speed, and Volume.
- Adds `aria-label` to "Go To" input and button.
- Updates "1:1", "Fit H", "Fit V", "B", "L" buttons with descriptive accessible names.
- Verified with `pnpm check` and Playwright `get_by_label` checks.

This improves accessibility for screen reader users by ensuring all interactive controls have descriptive names.

Co-authored-by: soulllink <5329963+soulllink@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant