Skip to content

Conversation

@owickstrom
Copy link
Contributor

@owickstrom owickstrom commented Mar 6, 2025

Fails in CI if Cargo.lock is stale:

image

Fixes https://linear.app/sourcegraph/issue/GRAPH-1125/stale-cargo-lock-file-for-scip-bindings

Test plan

  • Test in CI

@owickstrom owickstrom requested a review from kritzcreek March 6, 2025 07:34
@owickstrom owickstrom force-pushed the owickstrom/cargo-lock-check branch from c0fc85d to 8ee0dcd Compare March 6, 2025 07:41
@kritzcreek
Copy link

Do we really want CI to fail on an unrelated PR, because some Rust dependency had an update in the meantime?

I'd think a lockfile really only makes sense when you're talking about a binary, whereas the bindings in here are used as a dependency, meaning the downstream application is going to pick the versions of transitive dependencies.

@owickstrom
Copy link
Contributor Author

@kritzcreek OK yeah, it might be too aggressive. The problem we had originally was the protobuf dependency constraint, and the version of this library itself, had changed and that wasn't reflected in the lockfile.

@owickstrom
Copy link
Contributor Author

@kritzcreek I'll close this for now. If the problem persists we can revisit a more balanced take.

@owickstrom owickstrom closed this Mar 10, 2025
@kritzcreek
Copy link

SGTM, I think checking in the lock file for reproducible CI is probably a good idea. FWIW the lockfile in here does not affect what versions end up being picked in the downstream build in sg/sg.

@varungandhi-src varungandhi-src deleted the owickstrom/cargo-lock-check branch September 10, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants