feat: Upload google/guava and apache/pekko SCIP index #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses scip-java container to index Google Guava repository - Similar to index-k8s job but for Java instead of Go Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
- Consolidated two jobs into one with matrix strategy - Removed redundant parameters (upload_repo, container, install_go) - Derive values from scip_binary when possible - Reduced workflow from 112 to ~75 lines Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
Cache Maven artifacts to speed up scip-java runs that download many dependencies Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
…ific commands - Dropped id parameter, use repository name directly - Renamed checkout_repo to repository - Fixed Maven cache key to avoid hashFiles error - Added case statement to handle scip-go vs scip-java command differences Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
jupblb
force-pushed
the
michal/GRAPH-1255
branch
from
e374c4c to
187e388
Compare
Added `apache/pekko` and `arrow-kt/arrow`.
jupblb
force-pushed
the
michal/GRAPH-1255
branch
from
187e388 to
070a381
Compare
jupblb
changed the title
varungandhi-src
approved these changes
Aug 25, 2025
zfy0701
pushed a commit
to sentioxyz/scip
that referenced
this pull request
Sep 6, 2025
* Add index-guava job to SCIP examples workflow - Uses scip-java container to index Google Guava repository - Similar to index-k8s job but for Java instead of Go Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0 * Simplify workflow using matrix strategy - Consolidated two jobs into one with matrix strategy - Removed redundant parameters (upload_repo, container, install_go) - Derive values from scip_binary when possible - Reduced workflow from 112 to ~75 lines Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0 * Add Maven dependency caching for scip-java Cache Maven artifacts to speed up scip-java runs that download many dependencies Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0 * Refactor workflow: remove id param, fix Maven cache, handle tool-specific commands - Dropped id parameter, use repository name directly - Renamed checkout_repo to repository - Fixed Maven cache key to avoid hashFiles error - Added case statement to handle scip-go vs scip-java command differences Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0 * Add more JVM repositories Added `apache/pekko` and `arrow-kt/arrow`. --------- Co-authored-by: Amp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added https://github.com/google/guava to SCIP index uploads. Used matrix strategies - I think it'll pay off as we add more repositories. The only disadvantage is that we have some steps strictly related to scip binary (but not too many).
Part of GRAPH-1255. Used
ampfor editing: thread.Test plan