Skip to content

Conversation

kitchen-porter
Copy link
Contributor

Hey!
I ran Cookstyle 8.4.0 against this repo and here are the results.
This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with resources/container.rb

  • 71:3 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 204:18 warning: Lint/RedundantTypeConversion - Redundant to_a detected.
  • 474:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 475:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 476:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 477:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 478:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 479:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 480:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 481:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 482:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 483:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 484:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 485:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 486:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 487:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 489:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 490:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 491:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 492:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 493:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 494:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 495:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 496:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 497:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 498:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 499:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 500:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 501:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 502:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 503:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 504:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 505:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 506:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 507:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 508:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 509:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 510:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 511:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 512:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 513:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 516:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 517:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 518:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 519:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 520:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 521:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 522:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 524:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 525:13 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 528:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 529:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 530:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 531:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 532:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 533:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 534:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 535:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 536:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 537:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 538:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 694:43 convention: Style/RedundantParentheses - Don't use parentheses around a logical expression.

Issues found and resolved with resources/exec.rb

  • 10:3 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.

Issues found and resolved with resources/installation_package.rb

Issues found and resolved with resources/partial/_base.rb

Issues found and resolved with test/cookbooks/docker_test/recipes/container.rb

  • 314:5 convention: Layout/FirstHashElementIndentation - Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
  • 315:5 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 316:5 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
  • 317:3 convention: Layout/FirstHashElementIndentation - Indent the right brace the same as the first position after the preceding left parenthesis.

Issues found and resolved with: resources/container.rb

 - 71:3 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 204:18 warning: Lint/RedundantTypeConversion - Redundant to_a detected.
 - 474:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 475:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 476:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 477:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 478:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 479:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 480:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 481:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 482:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 483:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 484:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 485:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 486:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 487:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 489:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 490:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 491:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 492:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 493:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 494:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 495:9 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 496:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 497:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 498:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 499:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 500:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 501:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 502:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 503:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 504:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 505:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 506:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 507:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 508:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 509:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 510:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 511:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 512:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 513:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 516:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 517:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 518:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 519:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 520:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 521:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 522:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 524:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 525:13 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 528:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 529:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 530:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 531:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 532:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 533:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 534:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 535:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 536:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 537:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 538:11 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 694:43 convention: Style/RedundantParentheses - Don't use parentheses around a logical expression.

Issues found and resolved with: resources/exec.rb

 - 10:3 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.

Issues found and resolved with: resources/installation_package.rb

 - 122:5 convention: Style/RedundantReturn - Redundant return detected. https://rubystyle.guideno-explicit-return
 - 127:5 convention: Style/RedundantReturn - Redundant return detected. https://rubystyle.guideno-explicit-return

Issues found and resolved with: resources/partial/_base.rb

 - 30:11 convention: Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line. https://rubystyle.guideno-double-indent
 - 31:11 convention: Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line. https://rubystyle.guideno-double-indent
 - 32:11 convention: Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line. https://rubystyle.guideno-double-indent

Issues found and resolved with: test/cookbooks/docker_test/recipes/container.rb

 - 314:5 convention: Layout/FirstHashElementIndentation - Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
 - 315:5 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 316:5 convention: Layout/HashAlignment - Align the keys of a hash literal if they span more than one line.
 - 317:3 convention: Layout/FirstHashElementIndentation - Indent the right brace the same as the first position after the preceding left parenthesis.

Signed-off-by: kitchen-porter <[email protected]>
@kitchen-porter kitchen-porter requested a review from a team as a code owner September 20, 2025 01:03
Copy link

Slowest examples

Top 10 slowest examples (2.01 seconds, 29.65% of total time)
Example Description Time in seconds
spec/docker_test/container_spec.rb:728 docker_test::container runs execute[change_network_mode] 0.39011
spec/docker_test/installation_package_spec.rb:210 docker_test::installation_package version strings for Ubuntu 20.04 generates the correct version string ubuntu focal 0.29933
spec/docker_test/container_spec.rb:952 docker_test::container testing GPU support creates a container with GPU support 0.25692
spec/libraries/container_networks_spec.rb:26 docker_container gets ip_address_from_container_networks when docker API < 1.21 gets ip_address as nil 0.24094
spec/docker_test/service_spec.rb:73 docker_test::service creates docker_service[default] 0.15527
spec/docker_test/service_spec.rb:162 docker_test::service containerd does not exist creates docker_service[default] 0.14626
spec/libraries/container_spec.rb:70 docker_container creates a docker container with default options is expected to create docker_container "hello_world" 0.13621
spec/libraries/container_spec.rb:353 docker_container creates docker container with cgroupns option is expected to create docker_container "hello_world" 0.13507
spec/unit/resources/swarm_init_spec.rb:50 docker_swarm_init when swarm is already initialized does not run init command if already in swarm 0.12898
spec/unit/resources/swarm_join_spec.rb:54 docker_swarm_join when already in a swarm does not run join command if already in swarm 0.1284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant