9.) graph based decoding#1613
Open
shanaxel42 wants to merge 1 commit intosaxelrod-delete-old-detect-codefrom
Open
9.) graph based decoding#1613shanaxel42 wants to merge 1 commit intosaxelrod-delete-old-detect-codefrom
shanaxel42 wants to merge 1 commit intosaxelrod-delete-old-detect-codefrom
Conversation
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
from
2c604cf to
d4d995c
Compare
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
from
d4d995c to
4f75af8
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
8f72169 to
1e62cbe
Compare
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
2 times, most recently
from
016f5fb to
d654f41
Compare
Codecov Report
@@ Coverage Diff @@
## saxelrod-delete-old-detect-code #1613 +/- ##
===================================================================
+ Coverage 89.87% 90.24% +0.37%
===================================================================
Files 219 221 +2
Lines 8117 8550 +433
===================================================================
+ Hits 7295 7716 +421
- Misses 822 834 +12
Continue to review full report at Codecov.
|
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
2 times, most recently
from
d702eae to
60ac93e
Compare
10 tasks
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
2 times, most recently
from
f2cc8cf to
2879c3c
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
52e5912 to
7e24890
Compare
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
2 times, most recently
from
431ad13 to
9ac3b89
Compare
ttung
reviewed
Oct 25, 2019
|
|
||
|
|
||
| def _build_spot_traces_per_round( | ||
| round_dataframes: Dict[int, pd.DataFrame], |
Collaborator
There was a problem hiding this comment.
Suggested change
| round_dataframes: Dict[int, pd.DataFrame], | |
| round_dataframes: Mapping[int, pd.DataFrame], |
if you're not going to modify, might as well make it immutable.
| def _build_spot_traces_per_round( | ||
| round_dataframes: Dict[int, pd.DataFrame], | ||
| channels: Sequence[int], | ||
| rounds: Sequence[int] |
Collaborator
There was a problem hiding this comment.
does round_dataframes.keys() contain the same data?
| for i in range(len(conn_comps)): | ||
| df_tmp = df.loc[conn_comps[i], :] | ||
| kdT_tmp = KDTree(df_tmp.loc[:, [Axes.ZPLANE.value, Axes.Y.value, Axes.X.value]].values) | ||
| # Check if all spots whitin a conn component are at most 1 pixels away |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Check if all spots whitin a conn component are at most 1 pixels away | |
| # Check if all spots within a connected component are at most 1 pixels away |
| intensity_tables : Dict[int, IntensityTable] | ||
| Output from _merge_spots_by_round, contains mapping of intensity tables | ||
| from each round to all the spots detected in them. | ||
| channels, rounds : Sequence[int] |
Comment on lines
+523
to
+527
| search_radius : int | ||
| Euclidean distance in pixels over which to search for spots in subsequent rounds. | ||
| search_radius_max : int | ||
| The maximum (euclidian) distance in pixels allowed between nodes belonging | ||
| to the same sequence |
Collaborator
There was a problem hiding this comment.
kind of surprised these aren't floats
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
7e24890 to
d0e97c4
Compare
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
from
9ac3b89 to
0ace70b
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
d0e97c4 to
8c0b6ba
Compare
shanaxel42
force-pushed
the
saxelrod-graph-decoding
branch
from
0ace70b to
2ed0053
Compare
Collaborator
|
hey @mattcai can you review this PR? it would be nice to get it in to 0.3.0 if its ready |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## saxelrod-delete-old-detect-code #1613 +/- ##
===================================================================
+ Coverage 89.87% 90.24% +0.37%
===================================================================
Files 219 221 +2
Lines 8117 8550 +433
===================================================================
+ Hits 7295 7716 +421
- Misses 822 834 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the work done by @gapartel in #1482 and modifies it to exist within the new spot finding modules.
h_maxwas missing from out existing collection so I added it as well as tests for it.build_traces_graph_based()instead ofdecode_spots()PerRoundMaxwith the parameterTraceBuildingStrategies.GRAPH. Some examples can be shown in the notebookgraph_decoding.py