refactor: improve populator naming and handling of structs in unmarshaller #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the code to improve naming conventions and handling of struct unmarshalling. In particular, it renames the ModelFromCore interface to Populator, updates error messages accordingly, and adapts test cases and related functionality to the revised naming and approach.
- Replace ModelFromCore with Populator across the codebase.
- Update error messages and helper functions for improved clarity.
- Adjust tests to invoke marshaller.Populate instead of marshaller.PopulateModel.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| marshaller/unmarshaller.go | Updates to core model handling and required field validation using CoreModeler. |
| marshaller/populator.go | Renaming of interface from ModelFromCore to Populator and related changes in populateValue. |
| marshaller/*_test.go (various test files) | Tests modified to use the new Populator interface with updated naming. |
| extensions/* and arazzo/* | Adaptations to the new Populator interface in downstream packages. |
Comments suppressed due to low confidence (1)
arazzo/criterion/criterion.go:139
- In the Populate method of CriterionTypeUnion, the error message is printing the type of 'c' (the receiver) instead of 'source'. It should be updated to: return fmt.Errorf("expected core.CriterionTypeUnion, got %T", source).
return fmt.Errorf("expected core.CriterionTypeUnion, got %T", c)
📊 Test Coverage ReportCurrent Coverage: Coverage Change: 📉 -.2% (decreased) Coverage by Package
Generated by GitHub Actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.