-
Notifications
You must be signed in to change notification settings - Fork 8
chore(jsonschema): add convenience methods for schema and boolean value access #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+157
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeTheAwesome
requested changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few broken comments to fix up.
📊 Test Coverage ReportCurrent Coverage: Coverage Change: ✅ No change Coverage by Package
Generated by GitHub Actions |
BlakeTheAwesome
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup
Code cleanup and organization
jsonschema
Related to JSON Schema handling
maintenance
General maintenance tasks
refactor
Code refactoring without functional changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds convenience methods to the
JSONSchema
type for more intuitive access to schema and boolean values.Changes
IsSchema()
andGetSchema()
methods as semantic alternatives toIsLeft()
andGetLeft()
IsBool()
andGetBool()
methods as semantic alternatives toIsRight()
andGetRight()
jsonschema/oas3
package to use the new methodsMotivation
The previous
Left
/Right
terminology was not intuitive for users of the API. The new method names make it immediately clear that aJSONSchema
can be either a schema object or a boolean value, improving code readability and developer experience.Testing