initial support bolt12 offers #10110
Draft
+3,101
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
reviewed
Oct 6, 2025
ecdsa
reviewed
Oct 6, 2025
ecdsa
reviewed
Oct 6, 2025
| self.payment_key = payment_hash + payment_secret | ||
| Logger.__init__(self) | ||
|
|
||
| self.bolt12_invoice = bolt12_invoice |
ecdsa
reviewed
Oct 6, 2025
accumulator
force-pushed
the
bolt12
branch
5 times, most recently
from
fa47daa to
f10ae24
Compare
Member
|
I have pushed a new version of https://github.com/spesmilo/electrum/commits/test_blinded_payment_onion |
accumulator
force-pushed
the
bolt12
branch
10 times, most recently
from
6c10962 to
e7765dd
Compare
accumulator
force-pushed
the
bolt12
branch
9 times, most recently
from
310953d to
b34be45
Compare
more invoice validation
…g via blinded path
…res.with_assumed()
This allows restricting blinded paths to channels that have sufficient receive capacity for payment. NOTE: this might have privacy issues, as this can be used to probe channel capacity. Maybe randomize leeway?
add invreq_metadata validation
add no-receive-capacity test
…when we have tried all blinded paths and for none of them we could find a route and we have a network address available for the destination (either node_id or blinded path introduction point).
…out are ERROR state
Member
Author
|
rebase after #10230 |
… generated. add feature filter for blinded payment path peers do not check frozen setting for onion message channel peers improve docs
…n tlv_stream_name=='onionmsg_tlv'
consistently use invoice_from_payment_identifier()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains initial support for BOLT12
offerpayment identifiers,invoiceby sendinginvoice_requestvia onion messageinvoiceandinvoice_errorresponsesinvoicebolt11data structures likeLnAddr, to minimize changes in payment sending code pathinvoicecurrently stored inInvoice.lightning_invoicewith a prefix, because adding a new field to an@attr.sobject is a PITA when switching branches, final storage location TBD.add_offer,get_offer,delete_offerandlist_offersfor managing offers.invoice_requestand replies withinvoiceif request can be matched with an offer.notes w.r.t current state:
only firstoffer_pathinofferis queried, iteration of multipleoffer_pathis TODOpathininvoice_pathsis tried, iteration of multiplepathis TODOcalc_hops_data_for_blinded_paymentis not computing per-hop fee/amount/cltv values for blinded hops correctly yet.offers are not persistedaddslog, making the wallet file non-backward compatible