added support for peercoin v3 transactions #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello, can this be merged? |
|
Please rebase against current master, and make sure the CI checks pass. |
SomberNight
requested changes
Oct 18, 2022
| @@ -1,5 +1,5 @@ | |||
| import setuptools | |||
| version = '1.16.0' | |||
| version = '1.17.1' | |||
| extras_require={ | ||
| 'rapidjson': ['python-rapidjson>=0.4.1,<2.0'], | ||
| 'rocksdb': ['python-rocksdb>=0.6.9'], | ||
| 'rocksdb': ['python-rocksdb-static'], |
There was a problem hiding this comment.
why? this affects bitcoin users too, so needs proper justification
There was a problem hiding this comment.
That's the only way I could get it to be installed. Does the python-rocksdb package still work for you?
twmht/python-rocksdb#102
There was a problem hiding this comment.
well it works for the CI on current master.
but I guess it might be compiling against older rocksdb
Nevertheless, please open a separate PR (or issue) for the rocksdb change. It does not belong in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New deserializer for Peercoin which can handle new v3 transactions. Test added. Tests passing.