Skip to content

Add Parent FlagSet #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fahedouch wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Parent FlagSet #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,19 @@ func (f *FlagSet) AddFlagSet(newSet *FlagSet) {
})
}

// AddParentFlagSet adds parent FlagSet to f. If a flag and shorthand is already present in f
// the flag from parentSet will be ignored.
Copy link

@AkihiroSuda AkihiroSuda Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit testing

func (f *FlagSet) AddParentFlagSet(parentSet *FlagSet) {
if parentSet == nil {
return
}
parentSet.VisitAll(func(flag *Flag) {
if f.Lookup(flag.Name) == nil && f.ShorthandLookup(flag.Shorthand) == nil {
f.AddFlag(flag)
}
})
}

// Var defines a flag with the specified name and usage string. The type and
// value of the flag are represented by the first argument, of type Value, which
// typically holds a user-defined implementation of Value. For instance, the
Expand Down