Sign macOS binaries #179
Merged
Sign macOS binaries #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other repos aren't going to have the CODECOV_TOKEN secret that they need to be able to upload the coverage run anyway, so we might as well disable this.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on signing for macOS binaries. It requires 3 specific secrets to be set:
CODESIGN_CERTIFICATE,CODESIGN_CERTIFICATE_PASSWORD, andCODESIGN_IDENTITY. I have a fork where I have successfully run the release process including signing over here: https://github.com/spinel-coop/rv-dev/actions/runs/19624331291. Please feel free to verify the signatures on the macOS binaries generated by that Actions run.It's only adjacent rather than directly related, but I have started building our x86 macOS release by cross-compiling from an ARM macOS 14 runner, since there are no x86 runners on macOS 14. It seems better for compatibility to cross-compile and continue to support macOS 14 than to compile on x86 and have to drop users on 14.