Open
Conversation
nasbench
requested changes
Mar 26, 2026
detections/endpoint/detect_use_of_cmd_exe_to_launch_script_interpreters.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/detect_use_of_cmd_exe_to_launch_script_interpreters.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/detect_use_of_cmd_exe_to_launch_script_interpreters.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/detect_use_of_cmd_exe_to_launch_script_interpreters.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/scheduled_task_deleted_or_created_via_cmd.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/scheduled_task_deleted_or_created_via_cmd.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/scheduled_task_deleted_or_created_via_cmd.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/scheduled_task_deleted_or_created_via_cmd.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/scheduled_task_deleted_or_created_via_cmd.yml
Outdated
Show resolved
Hide resolved
…erpreters.yml Co-authored-by: Nasreddine Bencherchali <nasreddineb@splunk.com>
…erpreters.yml Co-authored-by: Nasreddine Bencherchali <nasreddineb@splunk.com>
…erpreters.yml Co-authored-by: Nasreddine Bencherchali <nasreddineb@splunk.com>
Co-authored-by: Nasreddine Bencherchali <nasreddineb@splunk.com>
Co-authored-by: Nasreddine Bencherchali <nasreddineb@splunk.com>
Contributor
Author
|
Thanks for the comments and suggestions @nasbench - i have pushed the fixes and can you have one more look? |
nasbench
approved these changes
Mar 27, 2026
Contributor
nasbench
left a comment
nasbench
left a comment
There was a problem hiding this comment.
Good work. LGTM.
I applied a final SPL beautify no logic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added filters to detections to reduce FPs from athena runs!