-
Notifications
You must be signed in to change notification settings - Fork 477
Fix the @Retry documentation #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0fbb1a3
to
ad388ae
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
=========================================
Coverage 81.88% 81.88%
+ Complexity 4728 4727 -1
=========================================
Files 463 463
Lines 14771 14771
Branches 1871 1871
=========================================
Hits 12095 12095
Misses 1988 1988
Partials 688 688
🚀 New features to boost your workflow:
|
592f7a9
to
a8dd99c
Compare
In addition, an optional `condition` closure can be used to determine if a feature should be retried. | ||
It also provides special support for data driven features, offering to either retry all iterations or just the failing ones. | ||
In its standard mode it only retries the feature method execution, but this can be changed using `mode` to | ||
also run setup and cleanup on retries. Even in this mode, the retry is only triggered if the feature method is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonard84 is this actually the intended and expected behavior?
That only expected failures in the feature method trigger a retry I mean.
I do some UI tests using Geb with Marathon driver and it happens sometimes on GHA that the application cannot be started and thus the driver throws an exception.
This is done in an iteration interceptor before calling proceed
, the iteration interceptor is within the retry iteration interceptor due to using global retry extension. But as the error happens there and not during feature method invocation, it does not cause a retry.
a8dd99c
to
e11ba73
Compare
e11ba73
to
801f260
Compare
c95e498
to
4ce80b2
Compare
4ce80b2
to
48c6bdc
Compare
No description provided.