-
Notifications
You must be signed in to change notification settings - Fork 476
Update to Gradle 9 #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 9 #2202
Changes from 8 commits
fa2dabf
fc5bb5d
0192ef9
61953bd
61dff17
0f8bfeb
8a30d67
0c4e078
fcd90e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
import org.springframework.boot.gradle.plugin.SpringBootPlugin | ||
|
||
/* | ||
* Copyright 2018 the original author or authors. | ||
* | ||
|
@@ -15,8 +17,18 @@ | |
*/ | ||
|
||
plugins { | ||
id "io.spring.dependency-management" version "1.0.5.RELEASE" | ||
id 'org.springframework.boot' version "2.5.3" | ||
// Normally, the Spring Boot 2 Gradle Plugin would not be compatible with Gradle 9+ | ||
// To get around this issue, we use the dependency-management plugin in isolation | ||
// as described here: https://docs.spring.io/spring-boot/docs/2.7.7/gradle-plugin/reference/htmlsingle/#managing-dependencies.dependency-management-plugin.using-in-isolation | ||
// This way, we get proper test execution and realistic version resolution on Gradle 9 | ||
id 'org.springframework.boot' version "2.7.18" apply false | ||
id "io.spring.dependency-management" version "1.1.7" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about instead removing the plugin from both places? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I initially wanted this PR to be as non-invasive as possible which is why I opted for this variant. I agree however that the bom variant would be much simpler. |
||
} | ||
|
||
dependencyManagement { | ||
imports { | ||
mavenBom SpringBootPlugin.BOM_COORDINATES | ||
} | ||
} | ||
|
||
// Spring dependency management downgrades the jupiter version to 5.7.2 otherwise | ||
|
Uh oh!
There was an error while loading. Please reload this page.