Add Groovy 5 support (#2196)

[Vampire]

No description provided.

[Vampire]

• Add Groovy 5 support (#2196) #2213 👈 (View in Graphite)
• Move spec internals methods to be static method calls #2209
• Use snapshotId instead of separate tests #2207
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

❌ Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.96%. Comparing base (12a35eb) to head (5568cbe).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...ockframework/mock/runtime/GroovyMockMetaClass.java	93.75%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2213      +/-   ##
============================================
+ Coverage     81.89%   81.96%   +0.07%     
- Complexity     4728     4741      +13     
============================================
  Files           463      465       +2     
  Lines         14771    14845      +74     
  Branches       1871     1873       +2     
============================================
+ Hits          12096    12167      +71     
- Misses         1987     1991       +4     
+ Partials        688      687       -1     

Files with missing lines	Coverage Δ
...java/org/spockframework/compiler/SpecRewriter.java	93.76% <100.00%> (ø)
...kframework/mock/runtime/GroovyMockInterceptor.java	89.65% <ø> (+15.46%)	⬆️
...ork/mock/runtime/GroovyRealGetPropertyInvoker.java	100.00% <100.00%> (ø)
...ork/mock/runtime/GroovyRealSetPropertyInvoker.java	100.00% <100.00%> (ø)
...ockframework/mock/runtime/GroovyMockMetaClass.java	92.85% <93.75%> (-0.63%)	⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[AndreasTu]

LGTM.

[AndreasTu]

@Vampire Is something left from your side?
From my side the PR would be ready to get merged.

[Vampire]

I don't think so, except for the question whether we pull out the the property forwarding into a separate PR before this PR, as this was already heavily broken and just not found and has not exactly much to do with this PR.

Other than that I think I'm also happy now and think we did an awesome piece work together here. :-)

[AndreasTu]

I would say we merge everything with this PR.

And thanks to you for the work on the PR. :)

[Vampire]

What's the verb you missed?
"keep"?
If you are just afraid of the work of splitting it, I could do that quickly, would be ready in about 5 minutes as separate PR. :-)

[Vampire]

Oh, well, too late, fine. :-D

[Vampire]

Now it looks like I did the dirty work you provided :-D 💪

[AndreasTu]

Now it looks like I did the dirty work you provided

I do not quite get what you mean..

[Vampire]

I mean it now looks like I fixed the property access f**** up that you solved. :-)
Would have liked to see that as commit coming from you, now I get the laurel (or blame) for it. :-D