Custom lock prefix #277
Open
Custom lock prefix #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to override the default "_lock{0}" template.
Fixes: 76
Change-Id: I22a6776168c78030e4472591a0c1e12a45b67cfb
sqla-tester
reviewed
Sep 16, 2025
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision dda8fff of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change dda8fff: https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/6116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends Redis/Valkey with a "lock_prefix" argument, which allows users to override the default "_lock{0}" template.
I proposed this 10 years ago, and have been using it in a custom backend. I keep forgetting to turn this into a PR.
The rationale for this PR: The current design uses a template of
"_lock{0}" % keywhich can be visually confusing to scan during manual audits: _lockkey1, _lockkey2, etc. This PR allows for"_lok.{0}" % key, which is easier to read: _lok.key1, _lok.key2, etc.A regex is used to validate the lock_prefix, restricting it to 2-10 chars
[A-Z0-9_-:.]A test for correct usage is provided. Because the test system uses setupclass, I could not think of a good way to implement bad config args.
Fixes: #76
Change-Id: I22a6776168c78030e4472591a0c1e12a45b67cfb