Skip to content

Adding .ConfigureAwait(false) to async library code #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding .ConfigureAwait(false) to async library code #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc30969
Added ConfigureAwait analyzers to help enforce ConfigureAwait(false) …
Feb 11, 2022
35f0a8b
Added all missing ConfigureAwait(false) statements.
Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions QueryBuilder/QueryBuilder.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@

</PropertyGroup>
<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Collections.Concurrent" Version="4.3.0" />
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions SqlKata.Execution/PaginationResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public PaginationResult<T> Next(IDbTransaction transaction = null, int? timeout

public async Task<PaginationResult<T>> NextAsync(IDbTransaction transaction = null, int? timeout = null, CancellationToken cancellationToken = default)
{
return await this.Query.PaginateAsync<T>(Page + 1, PerPage, transaction, timeout, cancellationToken);
return await this.Query.PaginateAsync<T>(Page + 1, PerPage, transaction, timeout, cancellationToken).ConfigureAwait(false);
}

public Query PreviousQuery()
Expand All @@ -89,7 +89,7 @@ public PaginationResult<T> Previous(IDbTransaction transaction = null, int? time

public async Task<PaginationResult<T>> PreviousAsync(IDbTransaction transaction = null, int? timeout = null, CancellationToken cancellationToken = default)
{
return await this.Query.PaginateAsync<T>(Page - 1, PerPage, transaction, timeout, cancellationToken);
return await this.Query.PaginateAsync<T>(Page - 1, PerPage, transaction, timeout, cancellationToken).ConfigureAwait(false);
}

public PaginationIterator<T> Each
Expand Down
Loading