fix: don't let null values in title or keywords break free-text search #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitner
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The free-text search feature for collections does not work when either
titleorkeywordsarenullin the collections table. By adding thecoalesce(content->'properties'->>'{field}', '') thetsquery` comparison will work even if those fields aren't set.resolves #344
Problem with incremental migration test
When I run
scripts/test --migrationsthe test that searches for a collection with anulltitle fails (it returns an empty list instead of the collection that it should find). This test passes in a database that is spun up from scratch, though. 🤔Update: fixed with a small tweak in the stageversion script