Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Sep 4, 2025

Description

Fixes #666

🟢 Local

--- PASS: kuttl (261.07s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/remote-logging_airflow-latest-3.0.1_openshift-false_executor-kubernetes (235.63s)
        --- PASS: kuttl/harness/remote-logging_airflow-latest-3.0.1_openshift-false_executor-celery (260.74s)
PASS

🟢 Jenkins nightly (existing nightly tests - without the new test)
🟢 Openshift remote-logging

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added in the issue

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Sep 4, 2025
@adwk67 adwk67 moved this to Development: In Progress in Stackable Engineering Sep 4, 2025
@adwk67 adwk67 marked this pull request as ready for review September 4, 2025 15:49
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Sep 4, 2025
@adwk67 adwk67 requested a review from a team September 5, 2025 07:08
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry is missing. The code changes look good to me.

@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 5, 2025
@adwk67
Copy link
Member Author

adwk67 commented Sep 5, 2025

Changelog entry is missing. The code changes look good to me.

Added here: 83232f4

@adwk67 adwk67 requested review from dervoeti and sbernauer September 5, 2025 13:51
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Sep 6, 2025
Merged via the queue into main with commit cd52d4a Sep 6, 2025
17 checks passed
@adwk67 adwk67 deleted the fix/remote-logging-3.x branch September 6, 2025 12:09
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Sep 6, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Airflow 3: Get S3 logging to work

5 participants