Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 1, 2025

Description

Fixes #694

Also did a bit of renaming variables to better reflect their prupose

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Release notes

Are in CHANGELOG.md
Current state:

  • Prevent Airflow connections from breaking in combination with Airflow 3.
    This was achieved by setting the AIRFLOW__CORE__FERNET_KEY env var

@sbernauer sbernauer added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 1, 2025
@sbernauer sbernauer self-assigned this Oct 1, 2025
@sbernauer sbernauer added release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug labels Oct 1, 2025
@sbernauer sbernauer requested a review from adwk67 October 1, 2025 11:11
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have started a test run here: https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/61/

2 test failures: both in remote-logging when attempting to set up minio...

@sbernauer sbernauer added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit fec5b37 Oct 1, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/set-fernet-key branch October 1, 2025 13:55
@lfrancke lfrancke removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 1, 2025
@lfrancke lfrancke moved this to Development: Done in Stackable Engineering Oct 1, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Oct 6, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Multiple Airflow 3 webservers crash because of fernet key missmatch

4 participants