-
-
Notifications
You must be signed in to change notification settings - Fork 133
Breez Wallet (Spark) #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: wallets
Are you sure you want to change the base?
Breez Wallet (Spark) #2575
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
da6434d
to
983a638
Compare
5d002d2
to
a318e4a
Compare
We are using node v18.20.4 in production according to package.json but the SDK mentions this: > Note: If using Node.js, the minimum supported version is v22. -- https://sdk-doc-spark.breez.technology/guide/install.html#javascripttypescript-wasm Maybe it will still work with v18.
b648893
to
f2dab0c
Compare
Hey @dangeross, since you mentioned to keep you updated, I hope you can help me with this: I read in the TG group that the public beta is next week. Is this related to the error I'm seeing in this video when calling
2025-09-28.23-23-39.mp4In the video, I am using a regtest invoice but it also happens with a mainnet invoice. The relevant code is in wallets/client/protocols/spark.js of this PR. |
Hey. It changed to |
But I am using |
Yep, I think only the latest includes it |
Ok, cool, this worked! I updated to v0.2.1. I also had to change I now get this expected error for regtest invoices:
When I try a mainnet invoice,
but it actually succeeds to pay the invoice! |
Can you raise this in Telegram if this is still an issue? |
Description
close #2538
TODO
sendPayment
fix receiving: I sent sats to the lightning address but the sats don't show up in thegetInfo()
call ...mhh, suddenly started working, maybe I did something wrong before?🚧 no, the above still happens. funding via lnurl doesn't always increase the balance, see Funding wallet via LNURLp does not always increase balance breez/spark-sdk#287
🚧 check implications of Node.js storage in prod: is there state that we cannot lose between deployments? if so, that should be in our database, not in sqlite via
better-sqlite
—but afaik, we're not using the SDK on the server. What about the data on the client in IndexedDB? Does it need to be synced with credentials across devices?❓ make sure user created backup of passphrase
❓ withdrawals to L1 (cooperative or unilateral)
🚧 'next' button of send form does not always pulse to indicate loading
Video
2025-09-23.15-46-12.mp4
Additional Context
tbd
Checklist
Are your changes backward compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
tbd
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
tbd
Did you use AI for this? If so, how much did it assist you?
no