Update module sigs.k8s.io/controller-runtime to v0.23.0 #3345
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
github-actions
bot
added
size/XS
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3345 +/- ##
==========================================
+ Coverage 64.86% 64.94% +0.07%
==========================================
Files 375 375
Lines 36596 36602 +6
==========================================
+ Hits 23738 23771 +33
+ Misses 10992 10966 -26
+ Partials 1866 1865 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@claude Analyze the k8s operator e2e test failures and the changes in this branch, and attempt to identify the cause of the test failures. |
|
Claude finished @dmjb's task in 6m 52s —— View job Analysis Complete: E2E Test Failure Root Cause
SummaryThe e2e tests are failing because the operator deployment cannot become ready. The root cause is missing webhook infrastructure (certificates, service, webhook configurations), not the controller-runtime v0.23.0 migration itself. Detailed AnalysisWhat Changed in This PRThe PR correctly migrates webhook code from controller-runtime v0.22.4 to v0.23.0: Changes in
These changes are correct per controller-runtime v0.23.0 breaking changes. The Real ProblemThe operator fails to start because:
Test Failure EvidenceThe deployment times out after 60 seconds waiting to become available, indicating the operator pod is not starting successfully or failing health checks. Why This Is Not a v0.23.0 Issue
Why Are Tests Failing Now?The tests are likely failing for one of these reasons:
The controller-runtime v0.23.0 release notes mention webhook changes but don't indicate they should cause startup failures without certificates. Recommended Fix OptionsOption 1: Disable Webhooks in E2E Tests (Quick Fix)Modify test setup to disable VMCP features: In - operator-deploy-local
- --
- --set
- operator.features.virtualMCP=false # Add this line
- --set
- operator.rbac.scope=namespaceThis unblocks the PR while webhooks remain available for manual/production use (where infrastructure can be configured separately). Option 2: Add Complete Webhook Infrastructure (Proper Fix)This requires:
This is the right long-term solution but requires significant work beyond this PR's scope. Option 3: Make Webhook Registration ConditionalModify RecommendationImplement Option 1 to unblock this dependency update PR. File a separate issue to track adding complete webhook infrastructure (Option 2) if webhooks are intended to be production-ready. The controller-runtime v0.23.0 migration is correct and should be merged once tests pass with webhooks disabled. Would you like me to implement Option 1 (disable webhooks in e2e tests)? |
Signed-off-by: Jeremy Drouillard <[email protected]>
|
I opened up this issue: #3360 for the long term fix for webhooks. |
github-actions
bot
added
size/S
Signed-off-by: Jeremy Drouillard <[email protected]>
github-actions
bot
added
size/S
Signed-off-by: Jeremy Drouillard <[email protected]>
github-actions
bot
added
size/S
This PR contains the following updates:
v0.22.4→v0.23.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.23.0🔆 Highlights
GetEventRecorderForrequires updating your rbac for events to use theevents.k8s.ioapiGroup rather than the `` (core) apiGroupbuilder.WebhookManagedBy(mgr).For(&corev1.Deployment{})has to be changed tobuilder.WebhookManagedBy(mgr, &appsv1.Deployment{})runtime.Object, for example fromValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error)toValidateCreate(ctx context.Context, obj *appsv1.Deployment) (admission.Warnings, error)✨ Features
🐛 Bugfixes
waitermanipulation by @fossedihelm in #3368🌱 Other
sorttoslicespackage by @dongjiang1989 in #3370📖 Documentation
README.md's compatibility matrix forv0.22.x. by @renormalize in #3392Dependencies
Added
Changed
bda5523→078029d5ec99f8→9bdfabea0af3ef→200df9985fd79d→ec3ebc5f3f2b99→589584f4c0f3b2→bc988d5cfa47c3→2d32026Removed
New Contributors
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.0...v0.23.0
Thanks to all our contributors! 😊
v0.22.5What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.4...v0.22.5
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.