Skip token injection when token exchange active #3385
+59
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When token exchange middleware is configured, it handles its own Authorization header injection. The oauth-token-injection middleware was being added anyway, potentially overwriting the exchanged token with the original OAuth token.
Add hasTokenExchangeMiddleware() to detect when token exchange is present and skip adding the redundant token injection middleware. Also fix the middleware name in proxy.go to use the MiddlewareType constant for consistent detection.
In practical terms what this enables is easier testing with:
What the fix enables is to read the token using the remote-auth