Skip to content

Conversation

@jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jan 21, 2026

Previously, specifying --remote-auth-bearer-token without also setting --remote-auth or --remote-auth-client-id would silently ignore the bearer token. The authentication flow was never triggered.

Add shouldHandleOutgoingAuth() that also checks for bearer token configuration via flag, file, or environment variable. When a bearer token is configured, it is now used as Priority 1 in the authentication flow, before OAuth discovery.

This enables using a pre-obtained bearer token for token exchange without requiring a full OAuth configuration.

Previously, specifying --remote-auth-bearer-token without also setting
--remote-auth or --remote-auth-client-id would silently ignore the
bearer token. The authentication flow was never triggered.

Add shouldHandleOutgoingAuth() that also checks for bearer token
configuration via flag, file, or environment variable. When a bearer
token is configured, it is now used as Priority 1 in the authentication
flow, before OAuth discovery.

This enables using a pre-obtained bearer token for token exchange
without requiring a full OAuth configuration.
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Jan 21, 2026
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.85%. Comparing base (0e4480b) to head (0ee1917).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3386      +/-   ##
==========================================
- Coverage   64.90%   64.85%   -0.06%     
==========================================
  Files         375      375              
  Lines       36599    36626      +27     
==========================================
- Hits        23755    23753       -2     
- Misses      10980    11000      +20     
- Partials     1864     1873       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yrobla
Copy link
Contributor

yrobla commented Jan 22, 2026

fix looks good, but could you add some testing to avoid regressions and ensure this doesn't fail again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants