feat: add support for github OIDC auth #133
Draft
+79,525
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgellow
force-pushed
the
sam/support-github-oidc-auth
branch
2 times, most recently
from
6e1ea79 to
b61ec67
Compare
dgellow
force-pushed
the
sam/support-github-oidc-auth
branch
from
b61ec67 to
ebafc43
Compare
|
Should be good, I'm waiting for API changes to be merged, deployed, and tested with this branch, then will move it to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GitHub OIDC as the default authentication method. For most users who already have our GitHub app installed for their SDK repos, this means no more creating API keys or configuring repo secrets.
Requirements for OIDC:
The GitHub app only needs to be installed in your org - it doesn't need access to the specific repo where workflows run.
API keys still work for cases where OIDC doesn't fit.
This change is backward compatible.