Add csi support #834
Open
Add csi support #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zanis <[email protected]>
|
@ZanisO can you plz pull changes from main and update your PR? and also update the readme; we will start its review next week. |
Felix-Stakater
requested changes
Sep 12, 2025
| var controllers []*controller.Controller | ||
| for k := range kube.ResourceMap { | ||
| if k == "secretproviderclasspodstatuses" { | ||
| if !options.EnableCSIIntegration { |
There was a problem hiding this comment.
Do we want to invert the setting as to having it enabled if no option is supplied?
if options.DisableCSIIntegration
| switch object := old.(type) { | ||
| case *v1.Namespace: | ||
| c.removeSelectedNamespaceFromCache(*object) | ||
| return |
There was a problem hiding this comment.
Moving this return to line 209 changes behavior
| oldSHAData = util.GetSHAfromSecretProviderClassPodStatus(r.OldResource.(*csiv1.SecretProviderClassPodStatus).Status) | ||
| config = util.GetSecretProviderClassPodStatusConfig(r.Resource.(*csiv1.SecretProviderClassPodStatus)) | ||
| } else { | ||
| logrus.Warnf("Invalid resource: Resource should be 'Secret' or 'Configmap' but found, %v", r.Resource) |
There was a problem hiding this comment.
This log message is no longer accurate.
| } else if _, ok := r.Resource.(*v1.Secret); ok { | ||
| oldSHAData = util.GetSHAfromSecret(r.OldResource.(*v1.Secret).Data) | ||
| config = util.GetSecretConfig(r.Resource.(*v1.Secret)) | ||
| } else if _, ok := r.Resource.(*csiv1.SecretProviderClassPodStatus); ok { |
There was a problem hiding this comment.
If you could turn this whole block into a type-switch I think that would look a lot cleaner
| } | ||
| } | ||
| } else if mountType == constants.SecretProviderClassEnvVarPostfix { | ||
| if volumes[i].CSI != nil && volumes[i].CSI.VolumeAttributes["secretProviderClass"] == volumeName { |
There was a problem hiding this comment.
Check if the secreetProviderClass is required.
|
@ZanisO are you around? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've attempted to implement ability to watch SecretProviderClassPodStatus, discussed in #440