ci: install formatter #1655
Open
ci: install formatter #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Aug 10, 2025
Comment on lines
+57
to
+60
| // [Theory] | ||
| // public void SyllableTest(string lyric, string hint, string[] aliases) { | ||
| // RunPhonemizeTest("en_arpa-plus", new NoteParams[] { new NoteParams { lyric = lyric, hint = hint, tone = "C3", phonemes = SamePhonemeParams(4, 0, 0, "") } }, aliases); | ||
| // } |
Author
There was a problem hiding this comment.
These lines caused dotnet format --verify-no-changes to fail because there are no test cases, so I commented this out.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a .NET formatter to the CI pipeline and applies automatic formatting to all source files in the OpenUtau project. The primary purpose is to ensure consistent code formatting across the codebase by running dotnet format --verify-no-changes in CI.
- Adds automated code formatting verification to CI pipeline
- Applies standardized formatting to all C# source files
- Reorganizes using statements in alphabetical order across the codebase
Reviewed Changes
Copilot reviewed 95 out of 197 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple .cs files | Reorganized using statements alphabetically and applied consistent brace formatting |
| OpenUtau/Views/*.axaml.cs | Reordered imports and standardized code formatting |
| OpenUtau/ViewModels/*.cs | Applied consistent formatting and import organization |
| OpenUtau/Controls/*.cs | Standardized braces placement and import ordering |
| OpenUtau.Plugin.Builtin/*.cs | Consistent formatting applied across phonemizer classes |
| OpenUtau.Core/*.cs | Applied standard formatting to core library files |
| OpenUtau.Test/*.cs | Formatted test files with consistent style |
Author
|
Ready for review. |
Owner
|
It's a bit too disruptive to reformat everything at this point.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1652 .
This PR adds
dotnet format --verify-no-changesin CI, and formats all files.