-
-
Notifications
You must be signed in to change notification settings - Fork 87
Testthat 3e #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testthat 3e #397
Conversation
… expect_equal() with ignore_attr = TRUE instead of equivalent
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 35 35
Lines 5750 5750
=======================================
Hits 5671 5671
Misses 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Doesn't seem like there is any speedup, but worth swapping to 3e anyway for updates. If runs consistently take longer than sequential, should probably swap back. |
|
Great, thank you. I just triggered ubuntu-latest (devel) to run again since it failed for some reason.
Yeah might as well switch back if there's no benefit. |
|
Hmm, still erroring only on ubuntu-latest (devel). Unclear why (not much to go on in the logs from what I can tell). Could maybe be a temporary GHA issue (those seem to happen from time to time). But I guess could also be something we need to fix. |
|
I'm going to try disabling the parallel testing and see if that fixes it |
|
Neat that seemed to have fixed it. Some system bug? |
|
I guess, I'm not sure, it was pretty hard to tell anything useful from the logs. But glad it's fixed. The rest of this PR looks good. I'll go ahead and merge. |
Changed syntax to match testthat third edition syntax (swapped to non-deprecated functions and so on.) Also gitignored .vscode formula for code-oss editors workspace settings.
Closes #381.