Skip to content

Conversation

@VisruthSK
Copy link
Member

@VisruthSK VisruthSK commented Dec 8, 2025

Changed syntax to match testthat third edition syntax (swapped to non-deprecated functions and so on.) Also gitignored .vscode formula for code-oss editors workspace settings.

Closes #381.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (94f2365) to head (1da4d23).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          35       35           
  Lines        5750     5750           
=======================================
  Hits         5671     5671           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VisruthSK VisruthSK marked this pull request as ready for review December 8, 2025 04:12
@VisruthSK VisruthSK requested a review from jgabry December 8, 2025 04:12
@VisruthSK
Copy link
Member Author

VisruthSK commented Dec 8, 2025

Doesn't seem like there is any speedup, but worth swapping to 3e anyway for updates. If runs consistently take longer than sequential, should probably swap back.

@jgabry
Copy link
Member

jgabry commented Dec 8, 2025

Great, thank you. I just triggered ubuntu-latest (devel) to run again since it failed for some reason.

If runs consistently take longer than sequential, should probably swap back.

Yeah might as well switch back if there's no benefit.

@jgabry
Copy link
Member

jgabry commented Dec 8, 2025

Hmm, still erroring only on ubuntu-latest (devel). Unclear why (not much to go on in the logs from what I can tell). Could maybe be a temporary GHA issue (those seem to happen from time to time). But I guess could also be something we need to fix.

@jgabry
Copy link
Member

jgabry commented Dec 8, 2025

I'm going to try disabling the parallel testing and see if that fixes it

@VisruthSK
Copy link
Member Author

Neat that seemed to have fixed it. Some system bug?

@jgabry
Copy link
Member

jgabry commented Dec 8, 2025

I guess, I'm not sure, it was pretty hard to tell anything useful from the logs. But glad it's fixed. The rest of this PR looks good. I'll go ahead and merge.

@jgabry jgabry merged commit 21b05b5 into master Dec 8, 2025
6 checks passed
@jgabry jgabry deleted the testthat-3e branch December 8, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testthat V3

4 participants