Add swipe navigation to lightbox #6197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for your submission and apologies for the lateness in reviewing this. I'm running into some issues with this on Chrome on my Android device. Swiping left and right seemed to sometimes not work. It would work for a run of images then it swiping would just stop responding. I also noticed that its no longer possible to navigate left and right by tapping the image.
This is indeed of interest. |
Contributor
Author
|
I think the onTouch handlers I added are interacting badly with the existing onPointer handlers. I will work on fixing it. |
Contributor
Author
|
Updated. I think this is better, but the consolidation also increases the risk of breakage. |
sezzim
force-pushed
the
lightbox-swipe
branch
from
fc6ffa3 to
6a7cf1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds swipe navigation to the lightbox on touch devices. Changes the panning behavior to interrupt panning when the edge of the image is reached. In the implementation, an X/Y position of zero now means centered, and a non-zero position is an offset from that.
Relevant to #2538, but that asks for more than just swipe.
Separate from this PR, I have changes to auto-hide the lightbox controls, and to control wake lock, if that is of interest.