Broken runway #11
Draft
Broken runway #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more or less complete revamp of the snappy library aiming to: * clear out a lot of the duplicate code * remove some of the redundant API * unify the codebase behind a single, optimized "inner" encoder/decoder * unify the public API for in-memory and stream compression/decompression * improve performance As such, only the documented API remains backwards-compatible - the rest has been refactored, moved around and rewritten: * `import snappy` now exposes only in-memory encoders / decoders * framed format moved to `snappy` module, `snappy/framing` removed * faststreams integration moved to `snappy/faststreams` * minimal `std/streams` integration started in `snappy/streams` Other changes include: * up-to-date documentation * allocation- and exception-free API (uses some amount of stack memory) * a 2-3x improvement to both compression and decompression performance, putting the library mostly on par with the C++ implementation (see README) * the implementation was heavily inspired by the `C++` and `go` implementations, but somewhat simplified * nonetheless, the code uses a significant amount of unsafe code to work around inefficiencies in the safe subset of Nim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fails weirdly on some platforms - the fix appears to be to remove the call to
ensureRunwayas is done in 9d1d232