feat: validate target path in fill disk Prepare#185
Merged
Conversation
joshiste
force-pushed
the
fix/bm-13788
branch
4 times, most recently
from
eb306d3 to
d563f33
Compare
Call CheckPathWritableRunc or CheckPathWritableProcess (based on DisableRunc config) during Prepare to give the user an immediate error when the target directory does not exist or is on a read-only filesystem.
Test that fill disk fails cleanly for non-existent paths and read-only tmpfs mounts.
Anonymous structs with json tags are unnecessary since the config is just serialized to JSON. Plain maps are simpler and more readable.
joshiste
force-pushed
the
fix/bm-13788
branch
7 times, most recently
from
f05026c to
3cca95e
Compare
joshiste
force-pushed
the
fix/bm-13788
branch
from
3cca95e to
4966fc7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diskfill.CheckPathWritableRunc(orCheckPathWritableProcesswhen runc is disabled) in the fill disk action'sPreparemethod to verify the target directory exists and is writable before starting the attackTest plan
go vet ./...passesexthostpackage)testFillDiskInvalidPath)