Fix: Windows path conversion fails for forward-slash paths

[crwebb85]

• Forked changes from draft PR Add support for UNC paths on Windows #493
• Fixed [Bug] Windows path conversion fails for forward-slash paths #676
• Added Windows support for the test harness

Did not address comment #493 (review). Imo, we can handle that in the future.

[stevearc]

Question about using vim.fs.normalize and one small req for the tests

[stevearc]

Can we make use of vim.fs.normalize for any of this functionality? It seems to do some similar things (preserving leading double slashes) and I'd like to rely on the Neovim libs whenever possible.

[crwebb85]

Can we make use of vim.fs.normalize for any of this functionality?

In nightly it looks like it would work. I still need to try it out in the oil code but from some quick testing I think it would work, However, I don't think it would work if you want to continue supporting Neovim 0.8+. There were a lot of improvements to vim.fs.normalize in 2024 and one improvement in 2025 that we may need for it to function correctly.

https://github.com/neovim/neovim/blob/b1ae775de618e3e87954a88d533ec17bbef41cdf/runtime/lua/vim/fs.lua#L209-L231
https://github.com/neovim/neovim/blob/0ef27180e31671a043b28547da327cd52f1a87c4/runtime/lua/vim/fs.lua#L306-L352
https://github.com/neovim/neovim/blob/0c995c0efba092f149fc314a43327db7d105e1ad/runtime/lua/vim/fs.lua#L504-L612
https://github.com/neovim/neovim/blob/c1c007813884075a970198fbba918d568428d739/runtime/lua/vim/fs.lua#L587-L688
https://github.com/neovim/neovim/blob/5370b7a2e0a0484c9005cb5a727dffa5ef13b1ed/runtime/lua/vim/fs.lua#L596-L697

I could also do the normal if has version use vim.fs.normalize else use a copy of nightly's version if that sounds better.

[stevearc]

Neovim 0.9 came out almost 3 years ago, so I'm fine to drop support for 0.8 now. I only kept it this long because there was no strong motivation to remove it, but now there is!

[stevearc]

Instead of exploding this test, could we just have a

if not fs.is_win then
  -- add the cases that fail on windows
end

[crwebb85]

Is something like this what you have in mind?

  it("get_url_for_path", function()
    local cases = {
      { "", "oil://" .. util.addslash(vim.fn.getcwd()), skip_on_windows = true },
      {
        "term://~/oil.nvim//52953:/bin/sh",
        "oil://" .. vim.loop.os_homedir() .. "/oil.nvim/",
        skip_on_windows = true,
      },
      { "/foo/bar.txt", "oil:///foo/", "bar.txt", skip_on_windows = true },
      { "oil:///foo/bar.txt", "oil:///foo/", "bar.txt" },
      { "oil:///", "oil:///" },
      { "oil-ssh://user@hostname:8888//bar.txt", "oil-ssh://user@hostname:8888//", "bar.txt" },
      { "oil-ssh://user@hostname:8888//", "oil-ssh://user@hostname:8888//" },
    }
    for _, case in ipairs(cases) do
      local is_skip = case.skip_on_windows and uv.os_uname().version:match("Windows")
      if not is_skip then
        local input, expected, expected_basename = unpack(case)
        local output, basename = oil.get_buffer_parent_url(input, true)
        assert.equals(expected, output, string.format('Parent url for path "%s" failed', input))
        assert.equals(
          expected_basename,
          basename,
          string.format('Basename for path "%s" failed', input)
        )
      end
    end
  end)

[stevearc]

It's closer, but I think it would be cleaner to do something like

local cases = { ... }
if not uv.os_uname().version:match("Windows") then
  -- skip these tests on windows
  vim.list_extend(cases, {
    ...
  })
end