Skip to content

Conversation

@xiaoliu-heng
Copy link

@xiaoliu-heng xiaoliu-heng commented Aug 23, 2024

fix issue #409

@chrisbeardy
Copy link
Collaborator

thanks for this, I've been meaning to look into this issue as i think it may be the same problem as #356 and #405. Since you're on the train of thought, could you check if it fixes these issues too (or the same solution is required), be good to close all 3 issues in one go!

@xiaoliu-heng
Copy link
Author

yes, I have already tested it on the actual PLC hardware.

@xiaoliu-heng
Copy link
Author

but it should only fixed the device notification

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10521631021

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.926%

Totals Coverage Status
Change from base Build 10177041600: 0.0%
Covered Lines: 1721
Relevant Lines: 1813

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants