Conversation
…reate _pkgdown.yml, update DESCRIPTION Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
…efs, remove tutorials section, update installation) Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
…tch package conventions Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
…tograph depends on both Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
…ming conventions Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR appears to prepare the repository for a v0.1.0-style release by updating package documentation, adding GitHub automation (checks/releases/pkgdown), and expanding/refactoring tests around mark functions.
Changes:
- Added GitHub Actions workflows for PR checks and automated build/tag/release + pkgdown deployment.
- Updated README/DESCRIPTION/man pages to reflect
{netrics}’ role in the stocnet ecosystem and the*_by_*() / *_x_*() / *_in_*()naming. - Refactored tests to iterate over
node_is_*()/tie_is_*()functions across a small set of generated example networks; adjusted diffusion-related docs/examples; fixedtie_is_random()to return a tie mark.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
tests/testthat/test-model_play.R |
Removes diffusion “named network” tests. |
tests/testthat/test-mark_ties.R |
Adds a loop to sanity-check tie_is_*() functions across example networks. |
tests/testthat/test-mark_nodes.R |
Adds a loop to sanity-check node_is_*() functions across example networks. |
tests/testthat/helper-netrics.R |
Defines data_objs corpus (now using generated networks) for tests. |
R/mark_ties.R |
Fixes tie_is_random() to return a tie_mark. |
R/measure_features.R, man/measure_features.Rd |
Updates @seealso links to the net_by_*() naming. |
R/motif_census.R, man/motif_net.Rd |
Updates object2 parameter description wording. |
man/mark_select.Rd, man/mark_tie_select.Rd |
Updates examples to use node_by_*() / tie_by_*() functions. |
README.md, README.Rmd, DESCRIPTION |
Updates package positioning, naming conventions, and installation guidance. |
_pkgdown.yml |
Adds pkgdown site configuration and reference index structure. |
.github/workflows/pushrelease.yml |
Adds automated build + tag/release + pkgdown deploy workflow. |
.github/workflows/prchecks.yml |
Adds PR CI workflow for checks, binaries, coverage, lint, spelling. |
.github/* templates/docs |
Adds PR template, issue templates, contributing guide, code of conduct, gitignore. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| skip_if(grepl("tie_is_max|tie_is_min|tie_is_recovered", fn)) | ||
| skip_if(grepl("tie_is_imbalanced", fn) && ob == "twomode") | ||
| if(fn == "tie_is_path"){ | ||
| expect_s3_class(tie_marks[[fn]](data_objs[[ob]], 1, 2), "tie_mark") |
There was a problem hiding this comment.
tie_is_path() can error when there is no path between from and to (it samples from all_shortest_paths(...)$epath, which can be length 0). Since data_objs includes random graphs, this test can become flaky. Use a deterministic graph where a path from 1 to 2 is guaranteed (or adjust the test to handle the no-path case).
| expect_s3_class(tie_marks[[fn]](data_objs[[ob]], 1, 2), "tie_mark") | |
| deterministic_graph <- igraph::make_graph(edges = c(1, 2, 2, 3), directed = TRUE) | |
| expect_s3_class(tie_marks[[fn]](deterministic_graph, 1, 2), "tie_mark") |
…ty() treat unlabelled data
… manynet functions
|
@copilot can you create a NEWS.md file and populate it with the main changes in this first release? You will need to not only describe that all these functions have been moved from manynet, and of course some renaming, but also where there have been fixes etc. |
Co-authored-by: jhollway <5595229+jhollway@users.noreply.github.com>
No description provided.