feat: update health probe to make use of healthChecker #94
Conversation
JoaoBraveCoding
force-pushed
the
new-probe
branch
from
360da86 to
c7ff350
Compare
healthChecker was introduced in open-cluster-management-io/addon-framework#289 and it allow us to define a list of ProbeFields as before but it also allows us to define HealthChecker. HealthChecker has the ability to go through all the resultFields and decide which resources are mandatory and should trigger unheathly probes and which resources are optional
JoaoBraveCoding
force-pushed
the
new-probe
branch
from
c7ff350 to
7c15260
Compare
|
Blocked until open-cluster-management-io/addon-framework#289 merges |
|
/hold |
Pull Request Test Coverage Report for Build 14489606041Details
💛 - Coveralls |
|
@JoaoBraveCoding the addon-framework PR is merged. |
|
/unhold |
| { | ||
| ResourceIdentifier: workv1.ResourceIdentifier{ | ||
| Group: prometheusalpha1.SchemeGroupVersion.Group, | ||
| Resource: PrometheusAgentResource, | ||
| Name: PPAName, | ||
| Namespace: InstallNamespace, | ||
| }, | ||
| ProbeRules: []workv1.FeedbackRule{ | ||
| { | ||
| Type: workv1.JSONPathsType, | ||
| JsonPaths: []workv1.JsonPath{ | ||
| { | ||
| Name: paProbeKey, | ||
| Path: paProbePath, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
@thibaultmg I've added a probe to the Platform prometheus, feel free to request any changes in this. It I can also add for UWM if you want but I would also have to update the HealthChecker
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, thibaultmg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
HealthCheckerwas introduced in open-cluster-management-io/addon-framework#289 and it allow us to define a list ofProbeFields, as before, but it also allows us to defineHealthChecker. HealthChecker has the ability to go through all the resultFields and decide which resources are mandatory and should triggerunheathly probes and which resources are optional.
UI Before
UI After