add regex argument to string() & nullOrString()
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
============================================
+ Coverage 93.86% 93.88% +0.02%
- Complexity 459 461 +2
============================================
Files 72 72
Lines 1614 1620 +6
============================================
+ Hits 1515 1521 +6
Misses 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Once PHPStan is green. LGTM 👍 |
silasjoisten
approved these changes
Jul 17, 2025
OskarStark
reviewed
Jul 18, 2025
| } | ||
|
|
||
| if (null !== $regex) { | ||
| Assert::stringNotEmpty($regex); |
There was a problem hiding this comment.
Let's use trimmed non empty string here
There was a problem hiding this comment.
| } | ||
|
|
||
| if (null !== $regex) { | ||
| Assert::stringNotEmpty($regex); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds an optional
$regexparameter to the methods:ValueObjectTrait::nullOrString&ValueObjectTrait::string.Changes:
stringmethod now accepts an optional?string $regexparameter.regexis set, the value is validated against the given regex.\InvalidArgumentExceptionis thrown when regex is empty or the value not matches the expression.Motivation:
StoryBlok provides an regex validation for string fields.