Wip: Initial work on running game from the new editor #2796

ourabigdev · 2025-05-23T17:09:32Z

PR Details

This PR adds the ability to build the game project from within the new Avalonia-based editor. While the editor UI doesn't yet include a button for this feature, the F5 shortcut can be used to trigger the build.

Currently, this functionality only works on Windows due to the limitations of the Stride AssetCompiler, which is platform-specific. I have started laying the groundwork for supporting other platforms in the future, but I am currently unable to test this feature on my Linux machine.

Related Issue

Fixes or relates to issue: #2742

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My change requires a change to the documentation.
I have added tests to cover my changes.
All new and existing tests passed.
I have built and run the editor to try this change out.

…nto xplat-editor

Kryptos-FR

Initial review. I'll have a second look at it later. I'm busy this weekend.

Kryptos-FR · 2025-05-23T17:16:32Z

sources/Directory.Packages.props

    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.7.0" PrivateAssets="all" />
  </ItemGroup>
-</Project>
+</Project>


Unnecessary change

yeah those things where made automatically by vs I didn't touch that

It shouldn't be done by VS unless you have some non-standard config that overrides the .editorconfig that we have at the root of the repo. It has this line which forces each file to have a blank line at the end:

stride/.editorconfig

Lines 6 to 8 in f99bde2

[*]

end_of_line = crlf

insert_final_newline = true

Kryptos-FR · 2025-05-23T17:17:28Z

sources/editor/Stride.GameStudio.Avalonia/Stride.GameStudio.Avalonia.csproj

  </ItemGroup>

  <ItemGroup>
+    <PackageReference Include="Avalonia" />


Not wrong but it's not needed as it is implied by the other package references. I tend to keep the smallest list of dependencies.

it was added on it's own I thought I was already there

It's this one that is not necessary.

Kryptos-FR · 2025-05-23T17:17:51Z

sources/editor/Stride.GameStudio.Avalonia/App.axaml.cs

 using Avalonia;
 using Avalonia.Controls.ApplicationLifetimes;
 using Avalonia.Data.Core.Plugins;
+using Avalonia.Input;


Doesn't seem required.

yeah i forgot about that but should port the input checking function to this file

Kryptos-FR · 2025-05-23T17:18:45Z

sources/editor/Stride.GameStudio.Avalonia/ViewModels/MainViewModel.cs

+
+
+
+    private async void RunCurrentProject()


Don't use async void, always return a Task.

ok will look into that

Kryptos-FR · 2025-05-24T07:46:26Z

sources/editor/Stride.GameStudio.Avalonia/ViewModels/MainViewModel.cs

        OpenCommand = new AnonymousTaskCommand<UFile?>(serviceProvider, OnOpen);
        OpenDebugWindowCommand = new AnonymousTaskCommand(serviceProvider, OnOpenDebugWindow, () => DialogService.HasMainWindow);
        OpenWebPageCommand = new AnonymousTaskCommand<string>(serviceProvider, OnOpenWebPage);
+        RunCurrentProjectCommand = new AnonymousCommand(serviceProvider, RunCurrentProject);


You can use AnonymousTaskCommand for async methods.

Kryptos-FR · 2025-05-24T07:47:04Z

sources/editor/Stride.GameStudio.Avalonia/ViewModels/MainViewModel.cs

+            process.Start();
+            process.BeginOutputReadLine();
+            process.BeginErrorReadLine();
+            process.WaitForExit();


I'd prefer to use the async version.

See: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.process.waitforexitasync

sources/editor/Stride.GameStudio.Avalonia/Views/MainWindow.axaml.cs

…nto xplat-editor

ourabigdev · 2025-05-26T11:01:55Z

i reopened this one sorry for the other one I don't work with github a lot so I forget sometimes

Kryptos-FR · 2025-05-25T06:06:07Z

sources/Directory.Packages.props

    <AvaloniaBehaviorVersion>11.2.7.3</AvaloniaBehaviorVersion>
  </PropertyGroup>
  <ItemGroup>
-    <PackageVersion Include="Avalonia" Version="$(AvaloniaVersion)" />


Shouldn't be removed here.

i did that i keeped this one now and the other has been removed in past commit but it's still there idk why

Kryptos-FR · 2025-05-25T06:07:01Z

sources/editor/Stride.GameStudio.Avalonia/Stride.GameStudio.Avalonia.csproj

  </ItemGroup>

  <ItemGroup>
+    <PackageReference Include="Avalonia" />


It's this one that is not necessary.

Kryptos-FR · 2025-05-26T11:02:21Z

sources/editor/Stride.Core.Assets.Editor.Avalonia/Views/ImageResources.axaml

  </DrawingImage>
+
+  <DrawingImage x:Key="ImageStart">
+		<DrawingImage.Drawing>


2 spaces instead of tabs for indentation in XAML files

There seems to still be a mix of spaces and tabs.

If you are using Visual Studio, you can use Ctrl+E,D to format the current document. Or In Visual Studio code Ctrl+Shift+i.

Kryptos-FR · 2025-06-23T14:00:33Z

@ourabigdev I have fixed the conflicts and pushed a little cleanup. I also changed the PR to a draft since it might not be complete yet. I will do some testing and I might push new commits later.

Thanks for the contribution in any case.

ourabigdev · 2025-06-23T17:08:30Z

@ourabigdev I have fixed the conflicts and pushed a little cleanup. I also changed the PR to a draft since it might not be complete yet. I will do some testing and I might push new commits later.

Thanks for the contribution in any case.

Thanks for that yeah it's better for it to become a draft since I will not be able to work on it this month so I will be back at the start of July, I did make the run in editor on windows work with shortcut key and the run button but the run button is just put there randomly I still need to learn about the new editor layout and also more about avalonia so that I can make a similar design and positioning like the wpf editor, when I come back to coding in July I will try my best to finish the pr if I find the time

ourabigdev added 4 commits May 23, 2025 18:00

initial work in running game project from editor

2816cf4

Merge branch 'stride3d:xplat-editor' into xplat-editor

2946b8b

Update Directory.Packages.props

c334afa

Merge branch 'xplat-editor' of https://github.com/ourabigdev/stride i…

594cdd2

…nto xplat-editor

Kryptos-FR self-requested a review May 23, 2025 17:13

Kryptos-FR assigned ourabigdev May 23, 2025

Kryptos-FR added the area-GameStudio label May 23, 2025

Kryptos-FR added this to the Editor Rewrite - Phase 1 milestone May 23, 2025

Kryptos-FR added this to Avalonia Editor Rewrite May 23, 2025

Kryptos-FR moved this to In Progress in Avalonia Editor Rewrite May 23, 2025

Kryptos-FR reviewed May 24, 2025

View reviewed changes

ourabigdev added 2 commits May 24, 2025 23:29

some fixes includin going from async void to async Task

ef5a203

Update Stride.GameStudio.Avalonia.csproj

3c10136

ourabigdev closed this May 26, 2025

ourabigdev force-pushed the xplat-editor branch from ef5a203 to 9113e83 Compare May 26, 2025 10:12

github-project-automation bot moved this from In Progress to Done in Avalonia Editor Rewrite May 26, 2025

Merge branch 'xplat-editor' of https://github.com/ourabigdev/stride i…

db37d54

…nto xplat-editor

ourabigdev reopened this May 26, 2025

Kryptos-FR reviewed May 26, 2025

View reviewed changes

ourabigdev added 2 commits May 26, 2025 12:06

Update Directory.Packages.props

6b5a2c1

Update ImageResources.axaml

67283fc

Kryptos-FR moved this from Done to Review in Avalonia Editor Rewrite May 26, 2025

ourabigdev and others added 6 commits May 28, 2025 05:12

Merge branch 'stride3d:xplat-editor' into xplat-editor

6c4fe7f

Wip: base changes to add start button

9972240

Update MainViewModel.cs

0dcf077

Merge branch 'stride3d:xplat-editor' into xplat-editor

ba2c592

Merge branch 'xplat_editor' into ourabigdev_xplat-editor

dc3255c

Cleanup

0a56ef0

Kryptos-FR force-pushed the xplat-editor branch from 03e4086 to 0a56ef0 Compare June 23, 2025 13:57

Kryptos-FR marked this pull request as draft June 23, 2025 13:57

Kryptos-FR linked an issue Jun 23, 2025 that may be closed by this pull request

❗🟡𝐌 Build or run from the editor #2742

Open

Kryptos-FR added the work-estimate-L 2-7 Days of work. Should try to break down into smaller issues label Jun 23, 2025

Merge branch 'stride3d:xplat-editor' into xplat-editor

c39f273

Uh oh!

Wip: Initial work on running game from the new editor #2796

Are you sure you want to change the base?

Wip: Initial work on running game from the new editor #2796

Uh oh!

Conversation

ourabigdev commented May 23, 2025

PR Details

Related Issue

Types of changes

Checklist

Uh oh!

Kryptos-FR left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kryptos-FR May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ourabigdev commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kryptos-FR commented Jun 23, 2025

Uh oh!

ourabigdev commented Jun 23, 2025

Uh oh!

Uh oh!

Kryptos-FR May 28, 2025 •

edited

Loading