Skip to content

Conversation

@Twigz
Copy link
Collaborator

@Twigz Twigz commented Dec 1, 2025

Summary

  • Adds a new full flow test, to test the integration of crypto onramp from start to finish.
  • Changes Toast to Snackbar in the example to make testing a little easier.

Motivation

Automating the checkout process will catch future integration errors and make it easier to validate the onramp SDK continues to work.

Notes

Not very familiar with the current testing setup so let me know if I missed/added too much to the bitrise.yml.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@Twigz Twigz requested a review from lng-stripe December 1, 2025 16:11
@Twigz Twigz requested review from a team as code owners December 1, 2025 16:11
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 303.5 KiB │ 303.5 KiB │  0 B │ 457.7 KiB │ 457.7 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.5 KiB │   7.5 KiB │  0 B │   7.3 KiB │   7.3 KiB │  0 B 
    other │  95.2 KiB │  95.2 KiB │ -8 B │ 183.2 KiB │ 183.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ -8 B │  25.3 MiB │  25.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20457 │ 20457 │ 0 (+0 -0) 
   types │  6290 │  6290 │ 0 (+0 -0) 
 classes │  5051 │  5051 │ 0 (+0 -0) 
 methods │ 30674 │ 30674 │ 0 (+0 -0) 
  fields │ 17580 │ 17580 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3667 │ 3667 │  0
APK
   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 29.1 KiB │ -9 B │ 64.5 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 30.3 KiB │ -8 B │ 65.8 KiB │  0 B │ (total)

@Twigz Twigz changed the title StripeCryptoOnramp: Full Flow Test StripeCryptoOnramp: Full Flow E2E Test Dec 1, 2025
@Twigz Twigz added the accept-risky-change accept-risky-change label Dec 2, 2025
Copy link
Contributor

@lng-stripe lng-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM. @jaynewstrom-stripe could you look at the CI?

@emerge-tools
Copy link

emerge-tools bot commented Dec 3, 2025

2 builds increased size, 1 build decreased size

Name Version Download Change Install Change Approval
Stripe Identity Example
com.stripe.android.identity.example.theme1
22.3.0-theme1 (20) 4.2 MB ⬇️ 1 B 9.8 MB - N/A
⚠️ PaymentSheet Example
com.stripe.android.paymentsheet.example
22.3.0 (11) 6.4 MB ⬆️ 505.3 kB (8.53%) 15.0 MB ⬆️ 1.3 MB (9.66%) N/A
Financial Connections Example
com.stripe.android.financialconnections.example
22.3.0 (220300) 4.6 MB ⬆️ 1.5 kB (0.03%) 10.1 MB ⬆️ 799 B N/A

Stripe Identity Example 22.3.0-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: 0 B
Total download size change: ⬇️ 1 B

Largest size changes

Item Install Size Change Download Size Change
Other ⬇️ 0 B ⬇️ -1 B

PaymentSheet Example 22.3.0 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.3 MB (9.66%)
Total download size change: ⬆️ 505.3 kB (8.53%)

Largest size changes

Item Install Size Change Download Size Change
🗑 com.stripe.android.paymentsheet.model.PaymentOptionFactoryKt ⬇️ -65.1 kB ⬇️ -29.4 kB
📝 com.stripe.android.model.parsers.PaymentMethodJsonParser$CardJson... ⬆️ 62.6 kB ⬆️ 28.0 kB
🗑 com.stripe.android.financialconnections.ui.components.TextKt ⬇️ -61.9 kB ⬇️ -27.9 kB
🗑 com.stripe.android.link.ui.signup.SignUpScreenStateKt ⬇️ -58.4 kB ⬇️ -26.4 kB
📝 com.stripe.android.model.parsers.PaymentIntentJsonParser$Shipping... ⬆️ 58.6 kB ⬆️ 26.2 kB
View Treemap

Image of diff

Financial Connections Example 22.3.0 (220300)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 799 B
Total download size change: ⬆️ 1.5 kB (0.03%)

Largest size changes

Item Install Size Change Download Size Change
📝 com.stripe.android.paymentsheet.PaymentSheet$GooglePayConfigurati... ⬆️ 5.7 kB ⬆️ 2.7 kB
🗑 com.stripe.android.paymentsheet.PaymentSheet$Insets$Creator ⬇️ -5.5 kB ⬇️ -2.6 kB
Other ⬆️ 667 B ⬆️ 1.5 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@Twigz Twigz merged commit 61c5cf4 into master Dec 4, 2025
21 checks passed
@Twigz Twigz deleted the twigz/crypot-onramp-full-flow-test branch December 4, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accept-risky-change accept-risky-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants