-
Notifications
You must be signed in to change notification settings - Fork 696
StripeCryptoOnramp: Full Flow E2E Test #12070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Risky Change This is considered a risky change because it adjusts the sample app build.gradle, please review carefully. By adding the label |
|
Diffuse output: APK |
lng-stripe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test LGTM. @jaynewstrom-stripe could you look at the CI?
2 builds increased size, 1 build decreased size
Stripe Identity Example 22.3.0-theme1 (20)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| Other | ⬇️ 0 B | ⬇️ -1 B |
PaymentSheet Example 22.3.0 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.3 MB (9.66%)
Total download size change: ⬆️ 505.3 kB (8.53%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 com.stripe.android.paymentsheet.model.PaymentOptionFactoryKt | ⬇️ -65.1 kB | ⬇️ -29.4 kB |
| 📝 com.stripe.android.model.parsers.PaymentMethodJsonParser$CardJson... | ⬆️ 62.6 kB | ⬆️ 28.0 kB |
| 🗑 com.stripe.android.financialconnections.ui.components.TextKt | ⬇️ -61.9 kB | ⬇️ -27.9 kB |
| 🗑 com.stripe.android.link.ui.signup.SignUpScreenStateKt | ⬇️ -58.4 kB | ⬇️ -26.4 kB |
| 📝 com.stripe.android.model.parsers.PaymentIntentJsonParser$Shipping... | ⬆️ 58.6 kB | ⬆️ 26.2 kB |
Financial Connections Example 22.3.0 (220300)
com.stripe.android.financialconnections.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 799 B
Total download size change: ⬆️ 1.5 kB (0.03%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 com.stripe.android.paymentsheet.PaymentSheet$GooglePayConfigurati... | ⬆️ 5.7 kB | ⬆️ 2.7 kB |
| 🗑 com.stripe.android.paymentsheet.PaymentSheet$Insets$Creator | ⬇️ -5.5 kB | ⬇️ -2.6 kB |
| Other | ⬆️ 667 B | ⬆️ 1.5 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded


Summary
Motivation
Automating the checkout process will catch future integration errors and make it easier to validate the onramp SDK continues to work.
Notes
Not very familiar with the current testing setup so let me know if I missed/added too much to the
bitrise.yml.Testing