refactor: Sign in Google and Apple#15
Merged
michalurbanek merged 3 commits intomasterfrom Feb 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Google and Apple sign-in flows to simplify the authentication architecture by removing the intermediate sign_in_with_auth_credential_use_case and directly handling Firebase authentication within each provider-specific use case.
Changes:
- Separated loading states for Google and Apple sign-in buttons
- Consolidated sign-in completion logic into a single
_signInCompletionmethod - Removed intermediate credential handling use case and integrated Firebase sign-in directly into provider-specific use cases
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| authentication_state.dart | Split single isSigningIn flag into separate isGoogleSigningIn and isAppleSigningIn flags; refactored sign-in completion flow |
| authentication_page_content.dart | Updated loading state bindings to use provider-specific flags |
| authentication_event.dart | Added new error event type to handle sign-in errors |
| sign_in_with_google_use_case.dart | Refactored to directly handle Firebase sign-in and exception mapping |
| sign_in_with_apple_use_case.dart | Refactored to directly handle Firebase sign-in with platform-specific logic and exception mapping |
| sign_in_anonymously_use_case.dart | Simplified to only handle Firebase anonymous sign-in |
| sign_in_with_auth_credential_use_case.dart | Removed file - logic consolidated into provider-specific use cases |
| custom_exception.dart | Added Firebase error code mapping for 'web-context-canceled' |
| README.md | Removed completed TODO item |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michalurbanek
force-pushed
the
mu/refactor/sign_in
branch
from
89aa5d6 to
fbbcd2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored both Google and Apple sign in flows.