Fix output names of unsteady simulation#2418
Merged
pcarruscag merged 8 commits intodevelopfrom Jan 24, 2025
Merged
Conversation
Contributor
Author
|
I would also try to add the writing of the mesh in the CGNS format, although this can be done in another PR. |
Contributor
|
LGTM |
bigfooted
reviewed
Jan 14, 2025
pcarruscag
reviewed
Jan 15, 2025
pcarruscag
reviewed
Jan 22, 2025
pcarruscag
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
It solves two main issues in unsteady simulations:
1- if the history file is not updated during the simulation (ex. setting inner_iter = 0) the time iteration is not updated in the file output names.
2- mesh file output does not have the time iteration at the end.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.