Enhance impersonation detection for Microsoft Teams #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
in-test-rules
aidenmitchell
previously approved these changes
Nov 17, 2025
zoomequipd
requested changes
Nov 20, 2025
Member
zoomequipd
left a comment
zoomequipd
left a comment
There was a problem hiding this comment.
there are many benign matches in telemetry data.
peterdj45
dismissed
aidenmitchell’s stale review
looking further into mode likely benign matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding additional regex keywords to account for microsoft teams impersonation
also adding logic to override sender profile and explicit domain negations if the sender domain is not valid
Associated samples