Update impersonation_quickbooks.yml #3697
Open
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
in-test-rules
MSAdministrator
added
the
review-needed
zoomequipd
requested changes
Dec 24, 2025
Comment on lines
+72
to
88
| and ( | ||
| sender.email.domain.root_domain not in~ ( | ||
| 'intuit.com', | ||
| 'turbotax.com', | ||
| 'intuit.ca', | ||
| 'meliopayments.com', | ||
| 'qemailserver.com', | ||
| 'intuit.co.uk', | ||
| 'quickbooksonline.com', | ||
| 'tsheets.com' | ||
| ) | ||
| or ( | ||
| not headers.auth_summary.spf.pass | ||
| or not headers.auth_summary.dmarc.pass | ||
| or not 'fail' in~ distinct(map(headers.hops, .authentication_results.dkim)) | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
this might be better handled in a more standard way
and not (
sender.email.domain.root_domain in~ (
'intuit.com',
'turbotax.com',
'intuit.ca',
'meliopayments.com',
'qemailserver.com',
'intuit.co.uk',
'quickbooksonline.com',
'tsheets.com'
)
and coalesce(headers.auth_summary.dmarc.pass, false)
)
Member
|
removing the review-neeeded label until feedback addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding logic to detect if it comes from a sender and dmarc/spf/dkim fail then we need to know.
Associated samples
Associated hunts