forked from redis/redis
-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor of ActiveDefrag to reduce latencies #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
492ce51
Refactor of ActiveDefrag to reduce latencies
sundb c1c1363
Always use context for various stages
sundb c432b55
Refine comment for context
sundb 9d79bdc
Refine comment
sundb a5f01ae
Add license
sundb 7d4a3a0
Simplify the release of stage list
sundb 091ed0a
dont use bool
sundb f6971a9
Revert the change of timeEventNextId
sundb 1b53310
Revert the license change of db.c
sundb 6786d48
Revert some test changes
sundb d476272
Fix test
sundb 1569913
Add free fn for stage
sundb 339da6f
Move defrag_later into defragKeysCtx
sundb 3e68663
Style
sundb 7f855a1
Move forward ctx pointer
sundb 208ba72
Revert the uppper limit, and eliminate the lower limit
sundb b093f2b
Revert minor change
sundb a3ea9ac
Cleanup
sundb 5887864
Use constant DEFRAG_CYCLE_US to replace config active-defrag-cycle-us
sundb 266d378
Revert test
sundb bef633c
Refine the comment for DEFRAG_CYCLE_US
sundb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guybe7 i wanna delete this line, because sometimes when defrag test failed, this log takes up the entire screen and can only be downloaded.
https://github.com/sundb/redis/actions/runs/13263200768/job/37024279281
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH i think this log is useful.. maybe we can just turn off debug logs in the relevant tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test requires other debug logs.
it's ok., except for the trouble of downloading other is not a problem, let's keep it.