Use cls for update #146
Open
Use cls for update #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
What is the issue we are trying to address here? |
jldinh
reviewed
Sep 9, 2025
|
|
||
| # If the Project has Questions, convert each into a Question object | ||
| if hasattr(self, "questions"): | ||
| self.questions = self._convert_questions_to_objects(self.questions) |
There was a problem hiding this comment.
The project is mutated in-place but the questions are re-instantiated. Is that desirable?
It seems inconsistent.
There was a problem hiding this comment.
Definitely not desirable, but it seems relatively difficult to update questions in-place so I'd like to punt on that - see https://github.com/surge-ai/surge-python/blob/main/surge/questions.py#L41
|
@jldinh I think the current behavior is confusing, and ran into this issue when developing on top of it. I think there's rarely a need for maintaining a copy of the old state of the data when you update it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do in-place updates of the Project object for more predictable behavior