This repository was archived by the owner on Feb 6, 2023. It is now read-only.
bugfix(loadAssets): Fix the problem that failing at requsting a base6…#134
Open
voezy wants to merge 1 commit intosvga:masterfrom
Open
bugfix(loadAssets): Fix the problem that failing at requsting a base6…#134voezy wants to merge 1 commit intosvga:masterfrom
voezy wants to merge 1 commit intosvga:masterfrom
Conversation
…4 string as the src param of xhr.open in Internet Explorer.
liveme
reviewed
Mar 4, 2021
Contributor
liveme
left a comment
liveme
left a comment
There was a problem hiding this comment.
PR中的base64处理尚未区分svga 1.x与2.x版本。svga 1.x 即使是 base64也需要依赖JSZip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the problem that failing at requsting a base64 string as the src param of xhr.open in Internet Explorer.
处理IE无法使用base64字符串作为请求地址发起 xhr 请求的问题。
使用webpack打包后的base64时，若没有引入//s1.yy.com/ued_web_static/lib/jszip/3.1.4/??jszip.min.js,jszip-utils.min.js, 则在执行
parser.load(base64string)后，会使用以下逻辑加载svga，这段逻辑在 chromium 内核的浏览器中可以正常运行，但在IE中会出现"拒绝访问"的问题，因此参考程序原有相关逻辑，作出这个修改，对base64字符串不在xhr中进行处理(考虑到不希望另外引入多一个js的情况下)。希望可以考虑下是否并入此修改。