Skip to content

Conversation

@Kontinuation
Copy link
Contributor

@Kontinuation Kontinuation commented Dec 12, 2024

This fixes the race condition described in #7. The idea is pretty straightforward:

  1. If send() is called before comm is established, the message to send is buffered in buffered_msgs
  2. Once the comm is established, all buffered messages in buffered_msgs will be send sequentially to the frontend.

After applying this patch, we don't have to wait for comm to get ready before starting the SparkSession. We can start the SparkSession at any time and it will always work.

@derbeneviv
Copy link

@krishnan-r any chance this can be merged?
we tested it and it works for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants